Slow environments.known

[rebornix]

Type: Bug

When calling environments.known api, it seems to call vscode.extensions.all multiple times

vscode-python/src/client/common/application/extensions.ts

Line 54 in f671b9b

this.all.some(

vscode.extensions.all has no memorization so each call to it will scan through all extensions and create a copy of the extension info, when users have a decent amount of extensions, it is slow. For example, currently on my machine it can take 100+ms to resolve environments.known once.

Extension version: 2022.18.2
VS Code version: Code - Insiders 1.74.0-insider (Universal) (9d5741f, 2022-11-10T05:23:25.431Z)
OS version: Darwin x64 22.1.0
Modes:
Sandboxed: Yes

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	7, 6, 6
Memory (System)	32.00GB (0.04GB free)
Process Argv	--enable-proposed-api ms-vscode.vscode-notebook-history --enable-proposed-api vscode.notebook-editing --enable-proposed-api vscode.vscode-test-resolver --enable-proposed-api donjayamanne.kusto --enable-proposed-api donjayamanne.jupyterpowertools --enable-proposed-api rebornix.better-jupyter-errors --enable-proposed-api rchiodo.jupyter-tools --crash-reporter-id 1a907bbd-fa02-4595-81e0-63e1648afb31
Screen Reader	no
VM	0%

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30422396
pythontb:30258533
vsc_aa:30263845
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805:30301674
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
vscaat:30438846
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pylantcb52:30590116
vsccc:30564266
pyindex848:30577858
nodejswelcome1:30587009
gswce1:30602633
34cci188:30599831
pyind779:30600159
dbltrim-noruby:30604474

[karrtikr]

Thanks for diagnosing this, I have amended #20222 to not block on returning known on getting list of extensions, and taken the fix in for cached extensions.

[rebornix]

@karrtikr thanks! Delaying the telemetry check makes perfect sense 👍