Show a general warning prompt pointing to the upgrade guide when users attempt to run isort5 using deprecated settings#13717
Merged
karrtikr merged 2 commits intomicrosoft:masterfrom Sep 2, 2020
Conversation
karrtikr
force-pushed
the
isortporpmt
branch
from
923c981 to
8152729
Compare
Codecov Report
@@ Coverage Diff @@
## master #13717 +/- ##
==========================================
- Coverage 59.82% 59.82% -0.01%
==========================================
Files 675 675
Lines 37798 37820 +22
Branches 5445 5452 +7
==========================================
+ Hits 22612 22624 +12
+ Misses 14028 14019 -9
- Partials 1158 1177 +19
Continue to review full report at Codecov.
|
karrtikr
force-pushed
the
isortporpmt
branch
from
8152729 to
9c090d2
Compare
karthiknadig
approved these changes
Sep 1, 2020
…s attempt to run isort5 using deprecated settings
karrtikr
force-pushed
the
isortporpmt
branch
from
9c090d2 to
1af19ea
Compare
kimadeline
reviewed
Sep 1, 2020
karrtikr
force-pushed
the
isortporpmt
branch
from
43c880b to
3b11066
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kimadeline
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #13716 Fixes #13312
Note isort5 has a bug which does not allow users to use deprecated arguments in
python.sortImports.args, when using stdin like we do: PyCQA/isort#1447. It throws errors instead of printing the warning related to deprecation.I have identified the fix in isort5 and suggested it to them. After they release the fix, we'll need to upgrade isort again. In this PR I'm assuming isort5 has fixed the bug and we're getting errors with warning codes when user uses deprecated settings.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).