Update reducer to use new implementation of merge environments#14152
Merged
karthiknadig merged 5 commits intomicrosoft:mainfrom Oct 12, 2020
Merged
Update reducer to use new implementation of merge environments#14152karthiknadig merged 5 commits intomicrosoft:mainfrom
karthiknadig merged 5 commits intomicrosoft:mainfrom
Conversation
karrtikr
force-pushed
the
reducmerge
branch
from
dc5ef1a to
98c0387
Compare
Codecov Report
@@ Coverage Diff @@
## main #14152 +/- ##
==========================================
+ Coverage 59.94% 60.04% +0.10%
==========================================
Files 705 705
Lines 39101 39084 -17
Branches 5667 5662 -5
==========================================
+ Hits 23440 23469 +29
+ Misses 14429 14374 -55
- Partials 1232 1241 +9
Continue to review full report at Codecov.
|
kimadeline
approved these changes
Sep 30, 2020
src/client/pythonEnvironments/base/locators/composite/environmentsReducer.ts
Outdated
Show resolved
Hide resolved
karthiknadig
approved these changes
Oct 12, 2020
This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public
karthiknadig
force-pushed
the
reducmerge
branch
from
34ef50d to
25751db
Compare
Codecov Report
@@ Coverage Diff @@
## main #14152 +/- ##
==========================================
+ Coverage 59.28% 59.36% +0.08%
==========================================
Files 715 715
Lines 39956 39950 -6
Branches 5791 5788 -3
==========================================
+ Hits 23686 23716 +30
+ Misses 15021 14975 -46
- Partials 1249 1259 +10
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
luabud
pushed a commit
to luabud/vscode-python
that referenced
this pull request
Oct 26, 2020
…soft#14152) * Add PythonEnvInfo-related helpers. (microsoft#14051) This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public * Undo unintentional formatting changes * And? * Fix missing default * Fix linting Co-authored-by: Eric Snow <eric.snow@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't move
mergeEnvironments()as it's not specific to the reducer, can be used in resolver as well.