Fix export from interactive

[IanMatthewHuff]

For #14210

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Has a news entry file (remember to thank yourself!).
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated.
• Test plan is updated as appropriate.
• package-lock.json has been regenerated by running npm install (if dependencies have changed).
• The wiki is updated with any design decisions/details.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[IanMatthewHuff]

Looks like export from interactive wasn't actually broken from the nbconvert fix. It had been broken a while ago by the backup storage fix here.

245f393

@rchiodo I think that this would work if it was a bind(this) but from the code I'm not seeing why this was needed as part of the backup fix. Was this needed for a reason?

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59%. Comparing base (cfe12a7) to head (390c2c6).
⚠️ Report is 2889 commits behind head on main.

Files with missing lines	Patch %	Lines
...atascience/interactive-window/interactiveWindow.ts	0%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##            main   #14224   +/-   ##
======================================
- Coverage     59%      59%   -1%     
======================================
  Files        706      706           
  Lines      39183    39185    +2     
  Branches    5683     5683           
======================================
- Hits       23495    23494    -1     
+ Misses     14465    14454   -11     
- Partials    1223     1237   +14     

Files with missing lines	Coverage Δ
...atascience/interactive-window/interactiveWindow.ts	9% <0%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[IanMatthewHuff]

Should fix #14099

[DonJayamanne]

Oops, my bad, i fixed this in our internal branch

[IanMatthewHuff]

Two repo tax :(

[rchiodo]

Looks like export from interactive wasn't actually broken from the nbconvert fix. It had been broken a while ago by the backup storage fix here.

245f393

@rchiodo I think that this would work if it was a bind(this) but from the code I'm not seeing why this was needed as part of the backup fix. Was this needed for a reason?

I have no idea. Doesn't seem correct to me. I would guess some sort of merge problem. Why would I even change that line for backup? There was a lot of merging going on when I submitted this originally. I'd guess that's where I made the mistake

[IanMatthewHuff]

I have no idea. Doesn't seem correct to me. I would guess some sort of merge problem. Why would I even change that line for backup? There was a lot of merging going on when I submitted this originally. I'd guess that's where I made the mistake

@rchiodo Sounds good. That was what it looked like, but I wanted to make sure that I wasn't regressing something intentional.