Add "--no-pretty" as default argument to mypy

[lithammer]

This fixes an issue when the error text gets truncated because of project local settings. As you can see from the example below, the output with --pretty is wrapped (at 80 chars?) when piped.

The wrapped lines are truncated from the error message.

$ cat > pyproject.toml <<<EOF
[tool.mypy]
pretty = true
EOF

$ cat > foobar.py <<<
def foobar(a: int):
    pass

foobar("123")
EOF

$ mypy foobar.py
foobar.py:5: error: Argument 1 to "foobar" has incompatible type "str"; expected "int"
    foobar("123")
           ^
Found 1 error in 1 file (checked 1 source file)

$ mypy foobar.py | cat
foobar.py:5: error: Argument 1 to "foobar" has incompatible type "str";
expected "int"
    foobar("123")
           ^
Found 1 error in 1 file (checked 1 source file)

$ mypy --no-pretty foobar.py
foobar.py:5: error: Argument 1 to "foobar" has incompatible type "str"; expected "int"
Found 1 error in 1 file (checked 1 source file)

$ mypy --no-pretty foobar.py | cat
foobar.py:5: error: Argument 1 to "foobar" has incompatible type "str"; expected "int"
Found 1 error in 1 file (checked 1 source file)

Without --no-pretty:

With --no-pretty:

Fixes #16836

[lithammer]

For similar reasons it would probably be nice to add --no-error-summary and maybe --hide-error-context as well.

[karthiknadig]

@lithammer Thanks for the PR. Can you create a bug for this issue? and add a news item based on that issue number. Create a file <issue-number>.md under news/2 Fixes with content like:

<change log comment for this fix>.
(thanks [Peter Lithammer](https://github.com/lithammer))

For adding --no-error-summary and --hide-error-context, once you create the issue we can discuss if it should be added.

[lithammer]

Thanks for reviewing. I had a look at existing issues and it would seem that adding --no-pretty would also fix this issue:

• no visual indication of mypy pretty linting errors on path names of >80 chars #16836

Should I create a news item for that as well? Or should I perhaps just re-use that issue instead of creating my own?

[karthiknadig]

Yes you can use #16836 as the news file.

[ghost]

All CLA requirements met.

[lithammer]

Yes you can use #16836 as the news file.

Done!

[lithammer]

Error: "package.json" was edited but "package-lock.json" was not (the "skip package*.json" label can be used to pass this check)

Not sure what the deal is with this failing check... 🤷‍♂️ Tried to rebase, but no bueno.

[karthiknadig]

That is just a check to ensure we have not missed any package update in package lock. Cleared it with "skip package*.json"

[lithammer]

Anything more you need me to do?

[karthiknadig]

@lithammer nothing for now. We are doing some repo maintenance, we will merge this soon.