Set storage drive before changing directory on windows#17875
Merged
karrtikr merged 5 commits intomicrosoft:mainfrom Oct 29, 2021
Merged
Set storage drive before changing directory on windows#17875karrtikr merged 5 commits intomicrosoft:mainfrom
karrtikr merged 5 commits intomicrosoft:mainfrom
Conversation
|
|
Author
|
Thanks for the review, I'll check my codes again |
Author
|
I have changed my codes as mentioned above |
karrtikr
reviewed
Oct 29, 2021
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for working through my comments.
…d add another test
Author
|
I tried to add a new test for this, And update current test from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I create a pull request to fix issue #14730
Please review my PR, thanks.
Closes #14730