Skip to content

Add useYarn to ICreateVSIXOptions, IPublishOptions, and IPublishVSIXOptions#279

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
aaomidi:master
Aug 10, 2018
Merged

Add useYarn to ICreateVSIXOptions, IPublishOptions, and IPublishVSIXOptions#279
joaomoreno merged 1 commit intomicrosoft:masterfrom
aaomidi:master

Conversation

@aaomidi
Copy link
Copy Markdown

@aaomidi aaomidi commented Aug 9, 2018

No description provided.

@joaomoreno joaomoreno self-assigned this Aug 10, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Aug 10, 2018
@joaomoreno
Copy link
Copy Markdown
Member

Will look into this today.

Comment thread src/api.ts
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be instead instead of in place.

Comment thread src/api.ts
baseImagesUrl?: string;

/**
* Should Yarn be used in place of NPM
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before.

Comment thread src/api.ts
/**
* Should Yarn be used in place of NPM
*/
useYarn?: boolean;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems broken.

Comment thread src/api.ts
export function publishVSIX(packagePath: string, options: IPublishVSIXOptions = {}): Promise<any> {
return _publish({ packagePath, ...options });
} No newline at end of file
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line.

@joaomoreno joaomoreno merged commit 663c64e into microsoft:master Aug 10, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, July 2018, August 2018 Aug 10, 2018
@joaomoreno
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants