Skip to content

Remove stub type definition for commander#359

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
jamesgeorge007:hotfix/fixup-type-def
Jun 4, 2019
Merged

Remove stub type definition for commander#359
joaomoreno merged 1 commit intomicrosoft:masterfrom
jamesgeorge007:hotfix/fixup-type-def

Conversation

@jamesgeorge007
Copy link
Copy Markdown
Contributor

@types/commander package is deprecated.

commander provides its own type definitions and it is not required to install @types/commander as from the official npm package repository page.

commander provides its own type definitions
@jamesgeorge007
Copy link
Copy Markdown
Contributor Author

cc @joaomoreno

@joaomoreno joaomoreno merged commit 7cde772 into microsoft:master Jun 4, 2019
@joaomoreno
Copy link
Copy Markdown
Member

joaomoreno commented Jun 4, 2019

Thanks! 🍻

You just forgot the yarn.lock file changes.

PS: No need to ping, I am watching this repo.

@joaomoreno joaomoreno added this to the June 2019 milestone Jun 4, 2019
@joaomoreno joaomoreno self-assigned this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants