Skip to content

use ignore npm package instead of custom code for .vscodeignore#418

Merged
joaomoreno merged 2 commits intomicrosoft:mainfrom
jedwards1211:fix/ignore
Jun 4, 2021
Merged

use ignore npm package instead of custom code for .vscodeignore#418
joaomoreno merged 2 commits intomicrosoft:mainfrom
jedwards1211:fix/ignore

Conversation

@jedwards1211
Copy link
Copy Markdown
Contributor

@jedwards1211 jedwards1211 commented Jan 31, 2020

fix #417

ignore implements the .gitignore spec and is very thoroughly tested...best to outsource this logic

@jedwards1211 jedwards1211 changed the title use ignore npm package instead of half-baked custom code for .vscodeignore use ignore npm package instead of custom code for .vscodeignore Jan 31, 2020
@joaomoreno joaomoreno self-assigned this Feb 3, 2020
Base automatically changed from master to main February 10, 2021 14:44
@joaomoreno joaomoreno merged commit 57b293e into microsoft:main Jun 4, 2021
@joaomoreno
Copy link
Copy Markdown
Member

Sorry for the attrocious delay! Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reignoring subdirectories of an unignored directory in .vscodeignore doesn't work...use the ignore npm package instead of your own logic

2 participants