Revisit hardcoded timeout for resolving shell environment blocking first window open

[Ben-WD]

Issue Type: Bug

I'm developing a Node.js webserver application with the following launch configuration:

{
    // Use IntelliSense to learn about possible Node.js debug attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Program",
            "type": "node",
            "program": "${workspaceFolder}/dist/server.js",
            "request": "launch",
            "preLaunchTask": "npm: build"
        },
        {
            "type": "node",
            "request": "attach",
            "name": "Attach by Process ID",
            "processId": "${command:PickProcess}",
            "protocol": "inspector"
        }
    ]
}

This has been working perfectly until version 1.49 has been installed. Since then, I get the following error when launching the application:

Can't find Node.js binary "node": path does not exist. Make sure Node.js is installed and in your PATH, or set the "runtimeExecutable" in your launch.json

Output from echo $PATH:

/Users/ben/.rbenv/shims:/Users/ben/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/ben/Library/Android/sdk/platform-tools/

Out from which node:

/usr/local/bin/node

Of course I can add the argument runtimeExecutable to launch.json, but I think this should not be necessary.

VS Code version: Code 1.49.0 (e790b93, 2020-09-10T17:39:53.251Z)
OS version: Darwin x64 19.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.02GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (13)

Extension	Author (truncated)	Version
angulardoc-vscode	Ang	6.1.3
vscode-eslint	dba	2.1.8
xml	Dot	2.5.1
EditorConfig	Edi	0.15.1
vscode-npm-script	eg2	0.3.13
prettier-vscode	esb	5.6.0
php-debug	fel	1.13.0
twig-language-2	mbl	0.9.2
debugger-for-chrome	msj	4.12.10
vscode-react-native	msj	0.17.0
vscode-jest	Ort	3.2.0
vscode-icons	vsc	10.2.0
markdown-all-in-one	yzh	3.3.0

[connor4312]

Where do you have your PATH configured in that way? If you launch VS Code from the shell (code -- with no existing running VS Code instance) it will inherit those variables, but if you launch it from the desktop app it might not have the same variables

You can see the PATH that VS Code has by running Developer: Toggle Developer Tools and entering process.env.PATH in the console.

[Ben-WD]

@connor4312 Output from Developer tools console:

process.env.PATH
"/Users/ben/.rbenv/shims:/Users/ben/bin:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/share/dotnet:~/.dotnet/tools:/Library/Apple/usr/bin:/Users/ben/Library/Android/sdk/platform-tools/"

Since /usr/local/bin is in path, everything should be working. It has been working for month until 1.49 was installed automatically.

[qiulang]

I have the same problem after I upgraded to 1.49 !

Version: 1.49.0
Commit: e790b931385d72cf5669fcefc51cdf65990efa5d
Date: 2020-09-10T17:39:53.251Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 19.6.0

I hit this error

If I changed runtimeExecutable I hit the following error

If I changed runtimeExecutable and runtimeArgs I hit the following error

[connor4312]

That's coming from your shell.

In js-debug to find Node we run which node or where node in the current environment. https://github.com/microsoft/vscode-js-debug/blob/8581c0bcda559b775d8666fb5765641c4118498b/src/common/pathUtils.ts#L15 Your observation that running npm directly does not find Node validates that the environment is wrong in the ext host.

As a workaround, you may be able to get things to work by setting console: integratedTerminal in your launch config along with the runtime executable, so that your program is run in a real shell.

@sandy081 / @isidorn did something change in 1.49 that would interfere with the environment that the extension host receives?

[qiulang]

Hi added console: integratedTerminal fixed the problem, but even more strange is that after I restarted vscode the problem goes away!

I didn't remember whether I restarted vscode yesterday but today that did fix the problem!

[liheeng]

I had same problem after upgrading to 1.49.0.

[adambiggs]

Same problem after upgrading to 1.49.0. Problem went away after downgrading to 1.48.2.

[sandy081]

Sorry, I have no idea. If it is extensionHost related pinging @alexdima