Environment collection should not be applied on hidden terminals (non-windows)

[karrtikr]

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.85.0-insider
OS: Linux (codespaces)

WORKS FINE ON WINDOWS

Steps to Reproduce:

(.venv) in the terminal prompt is contributed via env collection by Python extension.

Normal terminal:

Hovering says that collection is applied.

Hidden terminal:

Although it says that no environment collection is contributed upon hovering, collection is still applied as can be seen in the terminal prompt.

[Tyriar]

@karrtikr it seems like this is actually a bug where the initially hidden terminal doesn't show the applied environments but should? Making a terminal hidden was just meant to be about visibility, not environment?

[karrtikr]

I'm fine if we change hidden terminals to also apply environment collection, as long as we get support for #194819.

Python extension decided not to send activate commands to hidden terminals: microsoft/vscode-remote-release#1760, as hidden terminals are considered private terminals belonging to a specific extension. One could probably argue similarly for not applying environment collection to such terminals.

[karrtikr]

Based on offline discussion we're continue to go with NOT applying environment collection to hidden terminals, due to it affecting remote scenarios.

[karrtikr]

We investigated that env collection from shell integration in unix is still being applied on hidden terminals, i.e applyAtShellIntegration: true is still being applied when it should not. Any further updates? @Tyriar