Environment collection replace API strips equals sign at the end

[xEverth]

VS Code version: Code - Insiders 1.84.0-insider (35419fc, 2023-10-27T10:41:08.734Z)
OS version: Windows_NT x64 10.0.19045

Try applying these variables using the environment collection API:

TEST_KEY="SOMETHING"
TEST_KEY_2="SOMETHING="
TEST_KEY_3=SOMETHING=
TEST_KEY_4='SOMETHING='

Even though screenshot says they're applied as expected:

equal sign is stripped from the end when printing the value:

Original bug report

Type: <b>Bug</b>

<!-- Please fill in all XXX markers -->
# Behaviour
## Expected vs. Actual

Expected:
Environment keys are read correctly, both in powershell and in python

Actual
When the .env file is set in the Python extension configuration, if the keys have equals sign they are stripped out, whether they are quoted or not. This happens both if the .env file is the default ${workspaceFolder}/.env or if this is changed. When the environments variables are loaded by the extension, this may change the behaviour of programs which use os.getenv("KEY") to retrieve the values.

## Steps to reproduce:

1. Have a .env file with the following content:

TEST_KEY="SOMETHING"
TEST_KEY_2="SOMETHING="
TEST_KEY_3=SOMETHING=
TEST_KEY_4='SOMETHING='

2) Set the path to this .env file in the Python extension settings (Python:Env File)

3) Open a new terminal (Powershell/Windows)

4) Check the value of the environment variables with $env:PATH

5) See that the '=' character at the end is stripped

6) Open a python interpreter and attempt loading the environment file again (python-dotenv)

7) The equal signs are still stripped

<!--
**After** creating the issue on GitHub, you can add screenshots and GIFs of what is happening. Consider tools like https://www.cockos.com/licecap/, https://github.com/phw/peek or https://www.screentogif.com/ for GIF creation.
-->

<!-- **NOTE**: Everything below except Python output panel is auto-generated; no editing required. Please do provide Python output panel. -->
# Diagnostic data

-   Python version (& distribution if applicable, e.g. Anaconda): 3.11.0
-   Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
-   Value of the `python.languageServer` setting: Pylance

<details>

<summary>Output for <code>Python</code> in the <code>Output</code> panel (<code>View</code>→<code>Output</code>, change the drop-down the upper-right of the <code>Output</code> panel to <code>Python</code>)
</summary>

<p>

From a python interpreter

from dotenv import load_dotenv; import os
with open(".env", "r") as f:
f.readlines()
os.getenv("TEST_KEY")
os.getenv("TEST_KEY_2")
os.getenv("TEST_KEY_3")
os.getenv("TEST_KEY_4")

This may print out SOMETHING in all 4 cases, without the = sign

Repeat after deactivating the environment variable loading from the Python extension and see the = sign for TEST_KEY_2, TEST_KEY_3 and TEST_KEY_4

</p>
</details>

<details>

<summary>User Settings</summary>

<p>

envFile: ""

venvPath: ""

venvFolders: ""

languageServer: "Pylance"

testing
• unittestEnabled: true

experiments
• optInto: ["pythonTerminalEnvVarActivation"]

</p>
</details>


Extension version: 2023.18.0
VS Code version: Code - Insiders 1.84.0-insider (35419fc016b8d3d5dbc59aa11a0be957b0897309, 2023-10-27T10:41:08.734Z)
OS version: Windows_NT x64 10.0.19045
Modes:

<details>
<summary>System Info</summary>

|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-10875H CPU @ 2.30GHz (16 x 2304)|
|GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled|
|Load (avg)|undefined|
|Memory (System)|31.84GB (16.35GB free)|
|Process Argv|--log trace|
|Screen Reader|no|
|VM|0%|
</details>
<!-- generated by issue reporter -->

[xEverth]

Showing the environment variables have the '=' after I unset Python: Env File

Showing the environment variables do not have '=' sign if loaded from the Python extension

[karrtikr]

Thanks for the bug report! We investigate issues in order based on priority and severity, which includes the impact it has on your ability to use the extension to do productive work, and the number of people affected. If other users come forward and leave a comment demonstrating they are seeing/reproducing the problem then we will raise this issue's priority. Thanks for understanding and the patience!

[xEverth]

Thank you. I'm adding some more information if it can be useful in finding the problem.

I cleared the python extension cache after re-setting the "Env File" setting, because I noticed it was loading a cached value.

2023-10-31 12:01:22.641 [debug] Shell path 'C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe', base path 'C:\Windows\System32\WindowsPowerShell\v1.0\powershell'
2023-10-31 12:01:22.641 [debug] Shell path identified as shell 'powershell'
2023-10-31 12:01:22.642 [debug] Setting environment variable AGENT_NAME in collection to MYNAME
2023-10-31 12:01:22.642 [debug] Setting environment variable KEY1 in collection to VALUE1
2023-10-31 12:01:22.643 [debug] Prepending environment variable PATH in collection with ${workspaceFolder}\.venv\Scripts;
2023-10-31 12:01:22.643 [debug] Setting environment variable KEY2 in collection to SOMETHING=
2023-10-31 12:01:22.643 [debug] Setting environment variable VIRTUAL_ENV in collection to ${workspaceFolder}\.venv
2023-10-31 12:01:22.643 [debug] Setting environment variable VIRTUAL_ENV_PROMPT in collection to .venv

Note that when reading here in the trace log, the environment variable KEY2 has the equal sign at the end, and it's in a different color.

The equal sign is also in the output of ".vscode-insiders/extensions/ms-python.python-2023.21.13041006/pythonFiles/printEnvVariables.py"

As far as I can tell the parsing code at https://github.com/microsoft/vscode-python/blob/491c2c8af29916136e0b6540b5d934bf448a51e3/src/client/common/variables/environment.ts#L141C2-L141C2 is correct, and captures all the equal signs in the key. Hence the sign appears in all of the logs in the output tab, it's just not there in the terminal and/or python if the .env file is loaded by the extension:

Last, I don't know if it's related, I'm getting the following debug messages from the Pylance extension:

2023-10-31 12:41:59.577 [debug] Extension ms-python.vscode-pylance accessed resolveEnvironment with args: {"id":"${workspaceFolder}.VENV\\SCRIPTS\\PYTHON.EXE","path":"${workspaceFolder}/.venv/Scripts/python.exe"}
2023-10-31 12:41:59.580 [debug] Extension ms-python.vscode-pylance accessed getActiveEnvironmentPath with args: undefined
2023-10-31 12:41:59.581 [debug] Extension ms-python.vscode-pylance accessed getEnvironmentVariables with args: undefined
2023-10-31 12:41:59.582 [debug] Extension ms-python.vscode-pylance accessed getActiveEnvironmentPath with args: undefined
2023-10-31 12:41:59.582 [debug] Extension ms-python.vscode-pylance accessed resolveEnvironment with args: {"id":"${workspaceFolder}\\.VENV\\SCRIPTS\\PYTHON.EXE","path":"${workspaceFolder}/.venv/Scripts/python.exe"}

[karrtikr]

Thanks, I'm able to reproduce it. Looks like an issue with environment collection API in VS Code itself, hence transferring.