Terminal link detection issues

[alexdima]

Testing #21021

linkComputer.test.ts contains a set of tests used for editor link detection. Some links that do not get fully detected in the terminal. Some do get detected, but partially or contain trailing periods, etc:

// Click here to learn more. https://go.microsoft.com/fwlink/?LinkID=513275&clcid=0x409
// Click here to learn more. https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).
aspx
<!-- !!! Do not remove !!!   WebContentRef(link:https://go.microsoft.com/fwlink/?LinkId=166007, area:Adm
in, updated:2015, nextUpdate:2016, tags:SqlServer)   !!! Do not remove !!! -->
For instructions, see https://go.microsoft.com/fwlink/?LinkId=166007.</value>
For instructions, see https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx.</
value>
x = "https://en.wikipedia.org/wiki/Zürich";
請參閱 http://go.microsoft.com/fwlink/?LinkId=761051。
x = "file:///foo.bar";
x = "file://c:/foo.bar";
x = "file://shäres/foo.bar";
Some text, then http://www.bing.com.

[Tyriar]

Upstream issue xtermjs/xterm.js#583

[Tyriar]

Another case from #21361:

bash-3.2$ echo "https://task.krümplr.com/signup?referral=51cfe998f397460200000001"
https://task.krümplr.com/signup?referral=51cfe998f397460200000001
bash-3.2$

[Tyriar]

Another case from #31460:

https://api.darksky.net/forecast/YOURAPIKEY/-23.5567497,-46.6541193'

[kachkaev]

I also face an issue with links that contain spaces:

# works
/path/to/file.yml

# does not work and I don't expect it to
/path/to/file with spaces.yml

# does not work, but it'd be great if it worked
/path/to/file\ with\ spaces.yml

# does not work too
/path/to/file%20with%20spaces.yml

After trying various combinations of backslashes, quotes etc., I could not find any means to make a path that contains spaces highlightable and clickable. This would be useful in linting reports.

UPD: Actually, supporting /path/to/file with space.yml would be probably a right thing despite that it's harder to implement – this would make the life of all command line tool developers easier.

The parser can find /path/to/file (before the first space) and then start eating forthcoming words while /path/to is a valid directory and until the eaten string matches the existing file or is too long to parse. Supporting spaces in non-file links is not necessary as this is not supported anyway.