fix emmet issue where wrong suggestions is promoted in html file#120480
Merged
rzhao271 merged 1 commit intomicrosoft:mainfrom Apr 5, 2021
Merged
fix emmet issue where wrong suggestions is promoted in html file#120480rzhao271 merged 1 commit intomicrosoft:mainfrom
rzhao271 merged 1 commit intomicrosoft:mainfrom
Conversation
rzhao271
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #107578
Issue
Unwanted emmet abbreviation is shown in an HTML file containing a <style> tag.
Issue Link -- #107578
Steps to repro
Type <style>input.</style> manually into an HTML file, after typing input. you'll notice input: .; is suggested.
The problem only occurs when typing css right before </style> close tag.
eg.
<style> input.| </style>will not promote the wrong suggestion but<style> input.|</style>will.Cause
Wrong boundary condition in
getEmbeddedCssNodeIfAnymakes getting EmbeddedCssNode for cases like<style>input.|</style>always fail.cc / @rzhao271