Fix welcome view links missing hover color#121835
Fix welcome view links missing hover color#121835joaomoreno merged 1 commit intomicrosoft:mainfrom sangxxh:issue/121521-tree-view-welcome-content-not-using-hover-link-color
Conversation
| } | ||
| })); | ||
|
|
||
| const onMouseOver = domEvent(this.el, 'mouseover'); |
There was a problem hiding this comment.
I'd recommend to instead follow the existing pattern for styling links on hover using CSS, for example here's how the search view does it:
vscode/src/vs/workbench/contrib/search/browser/searchView.ts
Lines 1977 to 1981 in f547ada
There was a problem hiding this comment.
I implemented it but realized it doesn't really work because Link is used in a few different places:
src/vs/workbench/browser/parts/viewssrc/vs/workbench/contrib/welcome/gettingStarted/browsersrc/vs/workbench/contrib/workspace/browser
So it doesn't look like there's a safe CSS selector that can cover all those cases and potential future consumers of Link.
What's your thought?
There was a problem hiding this comment.
You might add a class to the link's a element and style based on that, but I'll leave further review to @joaomoreno as he owns this code.
There was a problem hiding this comment.
Oh yes, that sounds like the way to do it. I'll have a go while waiting for @joaomoreno's review
There was a problem hiding this comment.
No luck with registerThemingParticipant yet, I'll wait for @joaomoreno 's review for now
glaukiol1
left a comment
glaukiol1
left a comment
There was a problem hiding this comment.
solid fix, thanks for contributing, also, please make a default color! thanks
|
Thanks! 🍻 Ended up cleaning up quite a bit how we style links. |
sangxxh
deleted the
issue/121521-tree-view-welcome-content-not-using-hover-link-color
branch
4 participants
This PR fixes #121521