add color customizations for inline debug values#123065
add color customizations for inline debug values#123065isidorn merged 4 commits intomicrosoft:mainfrom nrayburn-tech:120936
Conversation
|
@nrayburn-tech this is a great PR, and works nicely -> approved. Let's just get @aeschli feedback on the color names. We are introducing: fyi @weinand |
src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts
Outdated
Show resolved
Hide resolved
|
@isidorn Looks good to me. |
|
After discussing with @aeschli we landed on the following names: The biggest discussion was around if
@nrayburn-tech can you please update the color names. |
isidorn
left a comment
There was a problem hiding this comment.
Please just update color name
|
@isidorn updated the names. I left the descriptions the same as I think debug is the only place that uses them, otherwise it could be more generalized like the name is. Let me know if you want anything else changed. |
|
Great, thanks a lot for updating the names. This PR looks good -> merging in ☀️ 👏 |
Modifies inline debug values to be allow color customizations/themes. Defaults should still be what they were previously, just converted to hex from rgba.
New color ids,
debugInline.decorationBackgroundanddebugInline.decorationForeground. The names may need to be changed to better align with the other ids.Example of modified colors.

This PR fixes #120936