Skip to content

add color customizations for inline debug values#123065

Merged
isidorn merged 4 commits intomicrosoft:mainfrom
nrayburn-tech:120936
May 19, 2021
Merged

add color customizations for inline debug values#123065
isidorn merged 4 commits intomicrosoft:mainfrom
nrayburn-tech:120936

Conversation

@nrayburn-tech
Copy link
Copy Markdown
Contributor

Modifies inline debug values to be allow color customizations/themes. Defaults should still be what they were previously, just converted to hex from rgba.

New color ids, debugInline.decorationBackground and debugInline.decorationForeground. The names may need to be changed to better align with the other ids.

Example of modified colors.
Screen Shot 2021-05-05 at 11 29 18 PM

This PR fixes #120936

@JacksonKearl JacksonKearl requested review from isidorn and removed request for isidorn May 6, 2021 05:43
@isidorn isidorn added this to the May 2021 milestone May 6, 2021
@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented May 6, 2021

@nrayburn-tech this is a great PR, and works nicely -> approved.

Let's just get @aeschli feedback on the color names. We are introducing:
debugInline.decorationBackground and debugInline.decorationForeground
What do you think about those?

fyi @weinand

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 18, 2021
@weinand
Copy link
Copy Markdown
Contributor

weinand commented May 18, 2021

@isidorn Looks good to me.

@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented May 18, 2021

After discussing with @aeschli we landed on the following names:
editor.inlineValuesBackground
editor.inlineValuesForeground

The biggest discussion was around if debug should be in the name or not. At the end we landed on NO because:

  • there is inlineValueProvider in the VS Code API and it is in the language namespace. Thus it does not have to be connected to a debugging
  • There is already stackFrameHighlight and focusedStackFrameHighlight colors which do not use the word debug

@nrayburn-tech can you please update the color names.
@weinand let me know if the names work for you

Copy link
Copy Markdown
Collaborator

@isidorn isidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just update color name

@nrayburn-tech
Copy link
Copy Markdown
Contributor Author

@isidorn updated the names. I left the descriptions the same as I think debug is the only place that uses them, otherwise it could be more generalized like the name is. Let me know if you want anything else changed.

@isidorn
Copy link
Copy Markdown
Collaborator

isidorn commented May 19, 2021

Great, thanks a lot for updating the names. This PR looks good -> merging in ☀️ 👏

@isidorn isidorn merged commit 5f6d478 into microsoft:main May 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inline Values Should be Themable

4 participants