Fix issue reporter not closing on submit and debounce submissions#123340
Fix issue reporter not closing on submit and debounce submissions#123340RMacfarlane merged 3 commits intomicrosoft:mainfrom nrayburn-tech:fix-115857
Conversation
|
Hey @nrayburn-tech, thanks for submitting this! The debounce is a great improvement! However, I don't think we want to close the reporter by default after the button is clicked. We can't guarantee that the issue has successfully been created on GitHub - we don't have any control after the API to open the browser is called, so though unlikely, there's a chance it could fail after that. To avoid losing data we keep the reporter open. |
This reverts commit 780ce8e.
|
I reverted the change, it should only have the debounce now and all other behavior the same. I was just aiming for consistency between the vscode/src/vs/code/electron-sandbox/issue/issueReporterMain.ts Lines 384 to 389 in 134d9b1 |
Debounces the issue reporter submissions, so that a double click doesn't submit two different issues.
Fixes the issue reporter not closing when an issue has been submitted successfully.
I tried to use the debounce decorator, but couldn't get it working correctly with a return value so I went with the Delayer.
Testing
This PR fixes #115857
Old Behavior

New Behavior
