Skip to content

Improve layout and resize events in terminal#123502

Merged
Tyriar merged 4 commits intomainfrom
tyriar/layout
May 10, 2021
Merged

Improve layout and resize events in terminal#123502
Tyriar merged 4 commits intomainfrom
tyriar/layout

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented May 10, 2021

The hope is that this fixes a bunch of layout and rendering-related bugs by improving the number of columns and rows of the terminal and ensuring layout events are correctly passed through.

Some big things:

  • bottom: 2px was only applied to .active terminals, so the height ended up sometimes coming through as NaN because bottom was set to auto
  • Within terminalGroup.ts we now always layout the terminal instances after adding a split, this will trigger 3 layouts: the first to add the split pane (disableLayout), the second to resize it using the sizing strategy (disableLayout) and then a final one which will actually resize the terminal.
  • Prevented race condition in _attachToElement by moving the xterm promise await after the elements are set on the instance

Fixes #120004
Fixes #120810
Fixes #108274

Tyriar and others added 2 commits May 10, 2021 11:12
@Tyriar Tyriar added this to the May 2021 milestone May 10, 2021
@Tyriar Tyriar self-assigned this May 10, 2021
This wasn't being used anymore
@Tyriar Tyriar merged commit 36416c8 into main May 10, 2021
@Tyriar Tyriar deleted the tyriar/layout branch May 10, 2021 20:26
@MohamedAliRashad
Copy link
Copy Markdown

@Tyriar
When can we expect a tested release for this problem ?

@Tyriar
Copy link
Copy Markdown
Contributor Author

Tyriar commented May 12, 2021

@MohamedAliRashad Insiders will probably be out today or tomorrow including this.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal buffer doesn't span full width Weird letter spacing in Integrated Terminal for VS Code Formatting issue in terminal

2 participants