Improve layout and resize events in terminal#123502
Merged
Conversation
Co-authored-by: Megan Rogge <[email protected]>
This wasn't being used anymore
This was referenced May 10, 2021
|
@Tyriar |
Contributor
Author
|
@MohamedAliRashad Insiders will probably be out today or tomorrow including this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hope is that this fixes a bunch of layout and rendering-related bugs by improving the number of columns and rows of the terminal and ensuring layout events are correctly passed through.
Some big things:
bottom: 2pxwas only applied to.activeterminals, so the height ended up sometimes coming through asNaNbecausebottomwas set toautoterminalGroup.tswe now always layout the terminal instances after adding a split, this will trigger 3 layouts: the first to add the split pane (disableLayout), the second to resize it using the sizing strategy (disableLayout) and then a final one which will actually resize the terminal._attachToElementby moving the xterm promise await after the elements are set on the instanceFixes #120004
Fixes #120810
Fixes #108274