Skip to content

Callback parameter for TestEditorService() is optional#20967

Merged
bpasero merged 1 commit intomicrosoft:masterfrom
dan-silver:remove-empty-function-param
Feb 21, 2017
Merged

Callback parameter for TestEditorService() is optional#20967
bpasero merged 1 commit intomicrosoft:masterfrom
dan-silver:remove-empty-function-param

Conversation

@dan-silver
Copy link
Copy Markdown
Contributor

Since the callback property is assigned an empty function in the constructor of TestEditorService, we shouldn't have to pass one in every time.

@mention-bot
Copy link
Copy Markdown

@dan-silver, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @egamma to be potential reviewers.

@msftclas
Copy link
Copy Markdown

Hi @dan-silver, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor. If you're full-time or an intern, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@bpasero bpasero merged commit 4ea410e into microsoft:master Feb 21, 2017
@bpasero
Copy link
Copy Markdown
Member

bpasero commented Feb 21, 2017

Thanks, LGTM

@bpasero bpasero added this to the February 2017 milestone Feb 21, 2017
@dan-silver dan-silver deleted the remove-empty-function-param branch February 21, 2017 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants