feature: replace electron File.path with electron webUtils

[SimonSiefke]

From the electron docs:

Warning: The path property that Electron adds to the File interface is deprecated and will be removed in a future Electron release. We recommend you use webUtils.getPathForFile instead.

This PR replaces the deprecated File.path property with the new electron webUtils api.

For testing:

Native Drag and Drop in the File Explorer:

1. Drag and drop a file from the native explorer to the vscode file tree
2. Verify the file is added to the vscode explorer

Normal Drag and Drop in the File Explorer:

1. Drag and drop a file from the vscode file tree to somewhere else in the vscode file tree
2. Verify the file is moved as expected in the vscode file explorer

Drag and Drop in the Terminal:

1. Drag and drop a file from the native explorer to the vscode terminal
2. Verify the file path appears in the terminal

[bpasero]

Thanks, I wasn't actually sure how to approach this when I saw it, so I will learn from your changes 🙏

[SimonSiefke]

Thanks!

Initially, I only added electron webUtils to the preload script and exposed it as a global variable webUtils. However, it didn't seem ideal for browser/fileActions.ts to depend on electron-sandbox/globals.ts. That's why I created the webUtils service, inspired by the webViewService.

[bpasero]

But I think a service that cannot be implemented for web is also not ideal. I think the right thing would be to depend on globals.ts from electron-sandbox and then move the actions that depend on it to electron-sandbox layers.

[bpasero]

See #213031 (comment)

[SimonSiefke]

Thanks for the feedback.

Do you have an example of similar code where that is applied? I'm not sure how I would proceed here:

// browser/fileActions.ts
export const pasteFileHandler = async (accessor: ServicesAccessor, fileList?: FileList) => {
	if (toPaste.type === 'paths' && item instanceof URI) {
		return item.path
	}
	// how to call something some electron-sandbox here without importing the file from electron-sandbox?
}

Thanks again!

[bpasero]

Yeah e.g. here:

vscode/src/vs/workbench/electron-sandbox/window.ts

Line 771 in 9f7eae5

const shellEnv = process.shellEnv();

For this, the action needs to be moved to a electron-sandbox namespace if possible.

[bpasero]

Since this action seems to be used in web as well, it probably should be subclassed on desktop to provide the extra functionality and then contributed per-web and per-desktop.

[SimonSiefke]

I like reusing the IHostService to simplify the code and added some changes to implement it. What do you think?

[bpasero]

@SimonSiefke I pushed c0298e5 to cleanup, I found many warnings (missing semicolons, etc), did you see them in the editor before committing? please check if things still work.

[SimonSiefke]

I forgot I had ESLint disabled, thanks for the fixes! Pasting files in the explorer and terminal is also still working for me!

[bpasero]

Thanks!