feature: allow unsetting color theme values in settings

[SimonSiefke]

fixes #128062, fixes #170576.

unset-color.mp4

[aeschli]

The PR would allow to set colors to null that could not be null before.
Currently a color can only be null if there's no default defined for it and nother the current theme sets not the color customizations define a color.
Other colors can, in practice, not be null, as the color defaults define a value
Themes currently can not set colors to null, and of course also not color customizations.

Although in the code we check for undefined, but we have never tested how the UI would look like if certain CSS rules are not present.

So in essence, this PR opens a fleabag of new configuration possibilities we have not tested.

Therefore I think we should not go in the suggested direction. Instead we should look at case-by-case where we want to allow that colors can be unset.

Note: it's already possible to set a color to transparent.

[SimonSiefke]

Thanks for the feedback! I agree it would not be good to set colors to null, potentially causing unexpected/undefined behaviour.

What do you think about instead of setting it to null, removing the property from colorMap so that customizations would only affect theme colors, but not the default colors.

E.g. with this color theme:

{
  "$schema": "vscode://schemas/color-theme",
  "type": "dark",
  "colors": {
    "activityBar.activeBackground": "#1f2727",
	"activityBar.activeBorder": "#00000000"
  }
}

and these settings:

{
	"workbench.colorCustomizations": {
		"activityBar.activeBackground": null
	}
}

the resulting colorMap would be

{
  "activityBar.activeBorder": "#00000000"
}

the same as if the color hasn't been defined in the color theme in the first place.

Thanks again!

[aeschli]

Yes, using null to reset a color to the default would be fine. But it's unclear to me how many problems this solves. It would only be useful for the colorCustomization settings.

[SimonSiefke]

Due to the PR being closed, I made some changes here: https://github.com/SimonSiefke/vscode/pull/14/files. What do you think?

[aeschli]

I simplified the PR by allowing default also in color theme files. It's not useful, but also not harmful and easy to handle. That eliminates the schema split.

[aeschli]

Thanks @SimonSiefke !