Only update viewlet switcher if it has already been rendered#28568
Merged
bpasero merged 2 commits intomicrosoft:masterfrom Jun 14, 2017
nicksnyder:activitybar
Merged
Only update viewlet switcher if it has already been rendered#28568bpasero merged 2 commits intomicrosoft:masterfrom nicksnyder:activitybar
bpasero merged 2 commits intomicrosoft:masterfrom
nicksnyder:activitybar
Conversation
This avoids a javascript error if unpin is called before the activity bar renders.
bpasero
requested changes
Jun 13, 2017
| this.pinnedViewlets.splice(index, 1); | ||
|
|
||
| this.updateViewletSwitcher(); | ||
| if (this.viewletSwitcherBar) { |
Member
There was a problem hiding this comment.
@nicksnyder should we not just move this check into the updateViewletSwitcher method? There are many more places where we call it.
Contributor
Author
There was a problem hiding this comment.
Makes sense, updated.
nicksnyder
changed the title
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a javascript error if unpin is called before the activity bar renders.