Slightly rework `mne.sys_info()`#11568

cbrnr · 2023-03-17T13:27:58Z

Fixes #11543, supersedes #11544.

larsoner

Looks good to me! But feel free to reorganize categories + headers if you're motivated to follow @drammock's suggestion in the PR (I thought the headers were nice). Also aesthetically I liked the change to parens instead of the braces for the extra info for NumPy/qtpy/PyVista if you want to port that over, too

larsoner · 2023-03-17T14:28:04Z

mne/commands/mne_sys_info.py

+                      help='Use Unicode symbols', action='store_true')
+    parser.add_option('-a', '--ascii', dest='unicode',
+                      help='Use ASCII symbols', action='store_false')


Most (all?) other commands where we have a default we do something like this instead

Suggested change

help='Use Unicode symbols', action='store_true')

parser.add_option('-a', '--ascii', dest='unicode',

help='Use ASCII symbols', action='store_false')

help='Use Unicode symbols instead of plain ASCII', action='store_true')

larsoner · 2023-03-17T14:33:29Z

But feel free to ...

I'm also happy to push a quick commit for some of this stuff if you want a break from this stuff :)

cbrnr · 2023-03-17T14:45:51Z

@larsoner yes, please go ahead! I didn't include the headers this time to keep the output shorter.

larsoner · 2023-03-17T17:31:12Z

Okay updated by iterating with @drammock during what we errantly thought were office hours trying various headers/left items etc., WDYT @cbrnr ?

$ mne sys_info
Platform:         Linux-5.19.0-35-generic-x86_64-with-glibc2.36
Python:           3.10.7 (main, Nov 24 2022, 19:45:47) [GCC 12.2.0]
Executable:       /home/larsoner/.local/bin/python
CPU:              x86_64 (8 cores)
Memory:           62.8 GB

Core
├☑ mne:              1.4.0.dev76+gbc47d98992
├☑ numpy:            1.25.0.dev0+364.g341afc9000 (OpenBLAS 0.3.21.dev with 1 thread)
├☑ scipy:            1.11.0.dev0+1286.bd120df
├☑ matplotlib:       3.8.0.dev425+g3aa5386c38 (backend=QtAgg)
├☑ pooch:            1.5.2
└☑ jinja2:           3.1.2

Numerical (optional)
├☑ sklearn:          1.3.dev0
├☑ numba:            0.57.0dev0+952.g1304e64d0
├☑ nibabel:          5.1.0.dev3+g7327927f
├☑ nilearn:          0.10.1.dev
├☑ dipy:             1.6.0dev0
├☑ openmeeg:         2.6.0.dev1
├☑ pandas:           1.6.0.dev0+206.g4baeede019
└☐ unavailable:      cupy

Visualization (optional)
├☑ pyvista:          0.39.dev0 (OpenGL 4.5.0 NVIDIA 470.161.03 via NVIDIA GeForce GTX 650 Ti BOOST/PCIe/SSE2)
├☑ pyvistaqt:        0.10.dev0
├☑ ipyvtklink:       0.2.2
├☑ vtk:              9.2.5
├☑ qtpy:             2.4.0.dev0 (PyQt6=6.4.0)
├☑ ipympl:           0.9.2
├☑ pyqtgraph:        0.12.4
└☐ unavailable:      mne-qt-browser

Ecosystem (optional)
├☑ mne_bids:         0.13.dev0
├☑ mne_nirs:         0.5.dev0
├☑ mne_connectivity: 0.6.0dev0
└☐ unavailable:      mne_features, mne_icalabel

The checkboxes are a bit small on GitHub but decent in a terminal:

But if those are too small we could use filled squares:

Core
├▣ mne:              1.4.0.dev76+gbc47d98992
├▣ numpy:            1.25.0.dev0+364.g341afc9000 (OpenBLAS 0.3.21.dev with 1 thread)
├▣ scipy:            1.11.0.dev0+1286.bd120df
├▣ matplotlib:       3.8.0.dev425+g3aa5386c38 (backend=QtAgg)
├▣ pooch:            1.5.2
└▣ jinja2:           3.1.2

Numerical (optional)
├▣ sklearn:          1.3.dev0
├▣ numba:            0.57.0dev0+952.g1304e64d0
├▣ nibabel:          5.1.0.dev3+g7327927f
├▣ nilearn:          0.10.1.dev
├▣ dipy:             1.6.0dev0
├▣ openmeeg:         2.6.0.dev1
├▣ pandas:           1.6.0.dev0+206.g4baeede019
└▢ unavailable:      cupy

cbrnr · 2023-03-17T19:12:43Z

Looks great! I like the checkboxes better than the filled ones, but I let you decide. Thank you!

larsoner · 2023-03-17T20:27:21Z

Okay back to boxes -- @drammock feel free to mark for merge if you're happy

cbrnr · 2023-03-17T18:52:21Z

azure-pipelines.yml

-        mne sys_info -pd | grep "qtpy: .*{PySide6=.*}$"
+        mne sys_info -pd | grep "qtpy: .* (PySide6=.*)$"
        pytest -m "not slowtest" ${TEST_OPTIONS}
        python -m pip uninstall -yq PySide6


Here I'd also uninstall PySide6-Essentials and PySide6-Addons.

hoechenberger · 2023-03-17T20:42:43Z

Great work! Can we remove the colons after the package names? I don't think they're needed since we use a tabular alignment. The unavailable I'd put in parens to make clear it's not a package name :)

agramfort · 2023-03-20T10:40:23Z

a few comments on this one.

It runs on my laptop but it took about a minute to print.

Also I get this

❯ mne sys_info
Platform:         macOS-13.2.1-arm64-arm-64bit
Python:           3.10.8 | packaged by conda-forge | (main, Nov 22 2022, 08:25:29) [Clang 14.0.6 ]
Executable:       /Users/agramfort/miniconda3/envs/mne/bin/python3.10
CPU:              arm (10 cores)
Memory:           32.0 GB

Core
├☑ mne:              1.4.dev0
├☑ numpy:            1.23.5 (OpenBLAS 0.3.21 with 10 threads)
├☑ scipy:            1.10.0
├☑ matplotlib:       3.7.0 (backend=MacOSX)
├☑ pooch:            1.6.0
└☑ jinja2:           3.1.2

Numerical (optional)
├☑ sklearn:          1.2.0
├☑ numba:            0.56.4
├☑ nibabel:          5.0.0
├☑ nilearn:          0.10.0
├☑ dipy:             1.5.0
├☑ openmeeg:         2.5.5
├☑ pandas:           1.5.3
└☐ unavailable:      cupy

Visualization (optional)
├☑ pyvista:          0.37.0 (OpenGL 4.1 Metal - 83 via Apple M1 Pro)
├☑ pyvistaqt:        0.9.0
├☑ ipyvtklink:       0.2.2
├☑ vtk:              9.2.5
├☑ qtpy:             2.3.0 (PyQt5=5.15.6)
├☑ ipympl:           0.9.2
├☑ pyqtgraph:        0.13.1
└☐ unavailable:      mne-qt-browser

Ecosystem (optional)
├☑ mne_bids:         0.13.dev0
├☑ mne_nirs:         0.6.dev0
└☐ unavailable:      mne_features, mne_connectivity, mne_icalabel
❯ which mne
/Users/agramfort/miniconda3/envs/mne/bin/mne
❯ mne browse_raw ~/mne_data/MNE-sample-data/MEG/sample/sample_audvis_raw.fif
❯ conda list | grep mne-qt
mne-qt-browser            0.4.0           py310hbe9552e_0    conda-forge

you can see that mne-qt-browser is installed and works but the new mne sys_info does not detect this. To me it's a bug...

* upstream/main: Fix bug in new `mne.sys_info()` (mne-tools#11577) Remove legacy plot_psd* funcs/methods in our docs and codebase (mne-tools#11563) The order of raw1.info["bads"] should not matter when concatenating with raw0.info["bads"] mne-tools#11501 (mne-tools#11502) MAINT: Fixes for matplotlib and pandas (mne-tools#11574) Fix Circle [circle deploy] Fix export to EDF format with a set physical range smaller than the data range (mne-tools#11569) Slightly rework `mne.sys_info()` (mne-tools#11568)

Slightly rework mne.sys_info()

cf82a1a

cbrnr mentioned this pull request Mar 17, 2023

Refactor mne.sys_info() #11544

Closed

3 tasks

larsoner reviewed Mar 17, 2023

View reviewed changes

ENH: Boxes, headers, categories

83867da

larsoner added 3 commits March 17, 2023 13:31

FIX: Variant 2

3119060

FIX: f

421709b

FIX: Paths

f1a99a0

FIX: Char

cd3fc23

cbrnr commented Mar 17, 2023

View reviewed changes

drammock enabled auto-merge (squash) March 17, 2023 20:59

drammock merged commit 417a9c4 into mne-tools:main Mar 17, 2023

cbrnr deleted the shorten-sysinfo branch March 20, 2023 07:34

drammock mentioned this pull request Mar 20, 2023

sys_info fails to find mne-qt-browser #11576

Closed

larsoner mentioned this pull request Mar 25, 2023

WIP / RFC: Rework sys_info output #11410

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Slightly rework `mne.sys_info()`#11568