MAINT: Simplify doc/conf.py#11657
Conversation
|
... now also removing the SphinxWindows job since it's unhelpful. Can easily restore it in #11656 if a workaround or fix lands in Sphinx |
| 'pyvista', | ||
| report_scraper, | ||
| mne.viz._scraper._MNEQtBrowserScraper(), | ||
| ) |
There was a problem hiding this comment.
I think it's okay to simplify this -- devs who want to build docs should have these installed I think.
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
LGTM so far! assuming there's more given the CI skip tags in your last commit?
No I just wanted to skip the ones that this shouldn't affect. But I could do a full run without any skips if it would help everyone sleep better at night :) The failure is |
good enough for me then. |
should we add an ignore for that in this PR then? |
|
We can just wait a day or two for joblib/joblib#1437 to fix their intersphinx refs |
2 participants
I realized
build_dev_htmlwas a relic of when we used to inject/modify our build based on being dev or stable. Removing this we can simplify ourMakefileto avoidmake html_dev-noplot-- we can just domake html-noplotas the result is the same. So I've simplified a bunch of stuff and tried to keep aliases for the old commands. I also updated to a newer sphinx iterator to avoid a Sphinx 6 warning.Note that the CircleCI artifacts redirector won't point to a valid file on this PR but it should once the PR is merged, as the redirector action only runs the
mainversion of the action.Helps a little bit with #11507