Skip to content

Visual regression diff fix#1068

Merged
LarsDenBakker merged 3 commits intomodernweb-dev:masterfrom
hklsiteimprove:visual-regression-diff-fix
Dec 9, 2020
Merged

Visual regression diff fix#1068
LarsDenBakker merged 3 commits intomodernweb-dev:masterfrom
hklsiteimprove:visual-regression-diff-fix

Conversation

@hklsiteimprove
Copy link
Copy Markdown
Contributor

@hklsiteimprove hklsiteimprove commented Dec 9, 2020

Problem

The generated artifacts for the failed and diff images couldn't be viewed.
The diff image was written both as the failed and as the diff.
The diff image was written incorrectly.

What I did

  1. Fixed bugs for diff and failed images generated by the visual-regression package

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 9, 2020

🦋 Changeset detected

Latest commit: bbe94a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-visual-regression Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hklsiteimprove hklsiteimprove force-pushed the visual-regression-diff-fix branch from aeabcfc to bbe94a2 Compare December 9, 2020 13:18
@LarsDenBakker LarsDenBakker merged commit c0633e4 into modernweb-dev:master Dec 9, 2020
@LarsDenBakker
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants