Feature: added iterationPause property#169
Merged
oblador merged 5 commits intooblador:masterfrom May 31, 2018
Merged
Conversation
oblador
reviewed
Jan 8, 2018
createAnimatableComponent.js
Outdated
| delay, | ||
| onAnimationBegin, | ||
| onAnimationEnd, | ||
| iterationPause, |
Owner
There was a problem hiding this comment.
Would prefer to name this iterationDelay instead to keep it consistent.
oblador
reviewed
Jan 8, 2018
createAnimatableComponent.js
Outdated
| } | ||
|
|
||
| animate(animation, duration) { | ||
| animate(animation, duration, iterationCount) { |
Owner
There was a problem hiding this comment.
This should be iterationDelay no?
oblador
reviewed
Jan 8, 2018
createAnimatableComponent.js
Outdated
| } | ||
|
|
||
| Animated.timing(animationValue, { | ||
| const delay = iterationPause ? { delay: iterationPause } : {} |
Owner
There was a problem hiding this comment.
Not a fan of this style, can't you just do it inline with a default to 0 like the others?
oblador
requested changes
Jan 8, 2018
Owner
oblador
left a comment
oblador
left a comment
There was a problem hiding this comment.
Cool! Some stylistic changes and a nit about naming otherwise good job!
Owner
|
@itchingpixels Thanks again for your PR. Are you planning on addressing the comments? |
|
Can't wait using it! |
Contributor
Author
|
I'll get this done in 24 hours :) |
Contributor
Author
|
done!:) |
oblador
approved these changes
May 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new, optional property to insert a pause between two iterations.
We're happy to update the README to include this, if everything is fine with this PR.
Closes #168