Disable iterationDelay delay on the beginning of animation#324
Merged
oblador merged 1 commit intooblador:masterfrom Oct 26, 2023
Merged
Disable iterationDelay delay on the beginning of animation#324oblador merged 1 commit intooblador:masterfrom
oblador merged 1 commit intooblador:masterfrom
Conversation
In the current version, when an "iterationDelay" is applied to pause the animation between iterations, the same iterationDelay is applied on the beginning of the first animation too. To apply pause/delay before the beginning of first animation, there already exists the "delay" prop. Changes in this pull request will make sure the"iterationDelay" is only applied to the second and subsequent animations.
|
can we get this merged and released? |
oblador
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version, when an "iterationDelay" is applied to pause the animation between iterations, the same iterationDelay is applied on the beginning of the first animation too. To apply pause/delay before the beginning of first animation, there already exists the "delay" prop.
Changes in this pull request will make sure the"iterationDelay" is only applied to the second and subsequent animations.
PS: The minor one line fix worked for me. Please take a look and let me know if I've missed any edge cases or done something wrong, I am happy to fix and resubmit the pull request in case any issues are found.