Skip to content

chore: golangci-lint issues on main#650

Merged
SoulPancake merged 1 commit intomainfrom
fix/golangci-lint-issues
Mar 17, 2026
Merged

chore: golangci-lint issues on main#650
SoulPancake merged 1 commit intomainfrom
fix/golangci-lint-issues

Conversation

@SoulPancake
Copy link
Copy Markdown
Member

@SoulPancake SoulPancake commented Mar 17, 2026

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Chores
    • Updated linting configuration to enforce naming standards across the codebase.
    • Removed a linting exception from the slices module.

@SoulPancake SoulPancake requested a review from a team as a code owner March 17, 2026 16:04
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6262ad5a-b8fd-4f45-b380-efdc6f6f1ccc

📥 Commits

Reviewing files that changed from the base of the PR and between 58b98cb and 77f4a24.

📒 Files selected for processing (2)
  • .golangci.yaml
  • internal/slices/slices.go
💤 Files with no reviewable changes (1)
  • internal/slices/slices.go

Walkthrough

Updates Go linting configuration to enforce naming conflict prevention for the internal/slices package and removes the corresponding nolint workaround directive from the source code.

Changes

Cohort / File(s) Summary
Linting Configuration
.golangci.yaml
Added revive linter rule under exclusions.rules for internal/slices path to prevent package names that conflict with Go standard library names.
Package Declaration
internal/slices/slices.go
Removed nolint directive from package declaration, eliminating the workaround that previously suppressed the naming conflict linting error.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: fixing golangci-lint issues by removing a nolint directive and adding linter configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/golangci-lint-issues
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SoulPancake SoulPancake changed the title fix: golangci-lint issues on main chore: golangci-lint issues on main Mar 17, 2026
@SoulPancake SoulPancake added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 27cdb0c Mar 17, 2026
22 checks passed
@SoulPancake SoulPancake deleted the fix/golangci-lint-issues branch March 17, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants