[stable10] owncloud coding standard

[phil-davis]

Backport #31442

The first commits backport the various interim php-cs-fixer changes from PR #31198 #31236 #31250 #31271 #31273

That was the easy way to make a list of cherry-picks that all fit nicely on top of each other. And its brings along the Makefile and drone changes etc that were already done before #31442

The last commit uses php-cs-fixer to make the automatic fixes needed for the code in stable10

lib/composer/bin/php-cs-fixer fix -v --diff --allow-risky yes

[codecov]

Codecov Report

Merging #31453 into stable10 will decrease coverage by 0.05%.
The diff coverage is 70.53%.

@@              Coverage Diff               @@
##             stable10   #31453      +/-   ##
==============================================
- Coverage       62.13%   62.07%   -0.06%     
+ Complexity      18241    18227      -14     
==============================================
  Files            1195     1195              
  Lines           71743    71827      +84     
  Branches         1248     1248              
==============================================
+ Hits            44574    44586      +12     
- Misses          26799    26871      +72     
  Partials          370      370

Flag	Coverage Δ	Complexity Δ
#javascript	52.64% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.1% <70.53%> (-0.07%)	18227 <660> (-14)

Impacted Files	Coverage Δ	Complexity Δ
...al/lib/Controller/UserGlobalStoragesController.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/files_external/lib/Lib/Auth/OAuth2/OAuth2.php	0% <ø> (ø)	0 <0> (ø)	⬇️
...s/federation/lib/Controller/SettingsController.php	92.3% <ø> (ø)	7 <0> (ø)	⬇️
apps/files/templates/index.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/federatedfilesharing/lib/TokenHandler.php	100% <ø> (ø)	2 <0> (ø)	⬇️
apps/files_external/lib/AppInfo/Application.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/files/templates/appnavigation.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/files/appinfo/app.php	25% <ø> (ø)	0 <0> (ø)	⬇️
apps/federatedfilesharing/lib/AdminPanel.php	100% <ø> (ø)	4 <0> (ø)	⬇️
apps/files_external/appinfo/app.php	0% <ø> (ø)	0 <0> (ø)	⬇️
... and 578 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af54ac4...0170270. Read the comment docs.

[patrickjahns]

Please wait until we have a final agreement when to do the backport

[phil-davis]

@patrickjahns @DeepDiver1975 now that the coding standard has been merged to master, this can also be reviewed and merged whenever you are happy.

Lately when doing backports I have been having to process "mindless" conflicts due to the previously-applied coding standards in master that has not been backported. So having this backport done in stable10 should make the code match better in the 2 branches and reduce "rubbish" conflicts.

master PR has been merged, this backport is ready for review now

[patrickjahns]

@phil-davis

There are some open tasks that need to be checked on stable10 - especially if native_function breaks polyfill components

[phil-davis]

PR #31657 has a newer/cleaner set of commits for this.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.