Skip to content

Specifically exclude anything other than the core bundled apps#31236

Merged
DeepDiver1975 merged 1 commit intomasterfrom
smarter-phpcs-apps-dir-selection
Apr 21, 2018
Merged

Specifically exclude anything other than the core bundled apps#31236
DeepDiver1975 merged 1 commit intomasterfrom
smarter-phpcs-apps-dir-selection

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

Description

Parse the apps directory and specifically exclude any apps that are not bundled with core.

Related Issue

None

Motivation and Context

When doing development in a git clone of core I often clone other apps into the apps folder.
This is causing make test-php-style to scan all those extra files in the apps, and report lots of errors.
This makes it difficult to see which are the few errors that are actually in the core branch I am fixing.

How Has This Been Tested?

make test-php-style
and see that it has the same length list of files checked as when used with a new git clone of core

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis phil-davis added this to the development milestone Apr 21, 2018
@phil-davis phil-davis self-assigned this Apr 21, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2018

Codecov Report

Merging #31236 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #31236    +/-   ##
==========================================
  Coverage     62.57%   62.57%            
- Complexity    18234    18397   +163     
==========================================
  Files          1145     1145            
  Lines         68396    68396            
  Branches       1234     1234            
==========================================
  Hits          42799    42799            
  Misses        25236    25236            
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.77% <ø> (ø) 18397 <ø> (+163) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2543f6...d12ccd1. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit de107ae into master Apr 21, 2018
@DeepDiver1975 DeepDiver1975 deleted the smarter-phpcs-apps-dir-selection branch April 21, 2018 23:47
@phil-davis
Copy link
Copy Markdown
Contributor Author

To backport after/with PR #31198

@phil-davis
Copy link
Copy Markdown
Contributor Author

Or might be superseded by ownCloud coding standard #31442

@phil-davis
Copy link
Copy Markdown
Contributor Author

Effective backport is included in #31453

@lock
Copy link
Copy Markdown

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants