Specifically exclude anything other than the core bundled apps#31236
Merged
DeepDiver1975 merged 1 commit intomasterfrom Apr 21, 2018
Merged
Specifically exclude anything other than the core bundled apps#31236DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #31236 +/- ##
==========================================
Coverage 62.57% 62.57%
- Complexity 18234 18397 +163
==========================================
Files 1145 1145
Lines 68396 68396
Branches 1234 1234
==========================================
Hits 42799 42799
Misses 25236 25236
Partials 361 361
Continue to review full report at Codecov.
|
DeepDiver1975
approved these changes
Apr 21, 2018
Contributor
Author
|
To backport after/with PR #31198 |
Contributor
Author
|
Or might be superseded by ownCloud coding standard #31442 |
Contributor
Author
|
Effective backport is included in #31453 |
This was referenced Jun 6, 2018
This was referenced Jul 20, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parse the apps directory and specifically exclude any apps that are not bundled with core.
Related Issue
None
Motivation and Context
When doing development in a git clone of
coreI often clone other apps into theappsfolder.This is causing
make test-php-styleto scan all those extra files in the apps, and report lots of errors.This makes it difficult to see which are the few errors that are actually in the core branch I am fixing.
How Has This Been Tested?
make test-php-styleand see that it has the same length list of files checked as when used with a new
git cloneofcoreTypes of changes
Checklist: