Center the logo and login fields#33375
Merged
DeepDiver1975 merged 1 commit intomasterfrom Jan 8, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33375 +/- ##
=========================================
Coverage 64.77% 64.77%
Complexity 18339 18339
=========================================
Files 1198 1198
Lines 69419 69419
Branches 1276 1276
=========================================
Hits 44963 44963
Misses 24087 24087
Partials 369 369
Continue to review full report at Codecov.
|
DeepDiver1975
requested changes
Nov 12, 2018
Member
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
Looks 💩 on desktop:
- too much space on top
- 2 pixel border on the right
Author
|
Fixed scrollbar and the space to the bottom
|
Member
|
nice
|
Force constant vertical height for login box over all devices
DeepDiver1975
force-pushed
the
login-center
branch
from
67077d8 to
8ea7159
Compare
DeepDiver1975
approved these changes
Jan 7, 2019
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Force constant vertical height for login box over all devices
Motivation and Context
I incorporate this function into almost every theme I create. The logo and credential fields are centered on each device. That's why I thought it would be great to integrate this improvement into our Core Theme.
How Has This Been Tested?
Tested on Chrome and Firefox browser with different resolutions
Screenshots (if appropriate):
Before:
After (1440x900px):
After (568x320px iPhone 5/5s/SE):
Types of changes
Checklist:
Open tasks: