received shares must go into share_folder when configured

[karakayasemi]

Description

Federates shares currently does not respect to configured share folder. This PR resolves this bug.

Related Issue

• Fixes [10.0.7] Federated shares doesn't appear in the /Shared folder #31342

Motivation and Context

Resolving bug.

How Has This Been Tested?

Manually by following below steps:
Scenario 1

• install two ownCloud instance
• add 'share_folder' => 'test' to config.php's of first instance
• share a file from second instance to first instance
• accept the share from first instance
• the file should be in test folder

Scenario 2

• install two ownCloud instance
• add second instance as a trusted server in first instance
• configure auto-accepting federated shares from trusted servers in first instance
• add 'share_folder' => 'test' to config.php's of first instance
• share a file from second instance to first instance
• the file should be in test folder

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #35312 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #35312      +/-   ##
============================================
+ Coverage     65.53%   65.56%   +0.03%     
  Complexity    18648    18648              
============================================
  Files          1218     1218              
  Lines         70548    70550       +2     
  Branches       1288     1288              
============================================
+ Hits          46235    46258      +23     
+ Misses        23936    23915      -21     
  Partials        377      377

Flag	Coverage Δ	Complexity Δ
#javascript	53.69% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.93% <100%> (+0.03%)	18648 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files_sharing/lib/External/Manager.php	89.63% <100%> (+13.09%)	32 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7684118...c9adc11. Read the comment docs.

[jvillafanez]

why the "call_user_func_array"?

[karakayasemi]

I followed syntax of the previous tests. I guess passing parameters as an array is easier.

[jvillafanez]

did this feature work with federated shares? Maybe we should include an additional option to use a different folder for federated shares (pinging @pmaier1 for this).
We could have shared_folder => Shared and federated_shared_folder => Federated_Shared, or both keys could also be set up to use the same folder.

[karakayasemi]

did this feature work with federated shares? Maybe we should include an additional option to use a different folder for federated shares (pinging @pmaier1 for this).
We could have shared_folder => Shared and federated_shared_folder => Federated_Shared, or both keys could also be set up to use the same folder.

There is an open issue for this feature and it was identified as bug. @pmaier1's thought is valuable for deciding whether separation of this configuration. I can modify the PR after decision.

[pmaier1]

I don't see a reason to split these folders. Why would you?

Generally speaking, federated sharing should be as transparent as possible to users (many users don't understand the concept), meaning for a regular user it should not make a difference whether a share is local or federated.

[micbar]

Tested in DamkenCloud. 👍

[micbar]

@karakayasemi please merge and backport.

[karakayasemi]

Backport PR: #35396

[cdamken]

now the share comes in the "/Shared" folder as desired.

But

in "Share with you" still doesn't appear the shares.

[karakayasemi]

Hmm, in the related issue description, I could not see anything about "Shared with you" problem. @cdamken we may raise a new ticket for it.

[cdamken]

Your are right, it was not described above, I just notice it now

we can create a new ticket for that

Thanks! 😄