[Stable10] detect correct uid when even wrong casing in given uid for files:scan#35344
Merged
karakayasemi merged 1 commit intostable10from May 28, 2019
Merged
[Stable10] detect correct uid when even wrong casing in given uid for files:scan#35344karakayasemi merged 1 commit intostable10from
karakayasemi merged 1 commit intostable10from
Conversation
11 tasks
phil-davis
approved these changes
May 28, 2019
Codecov Report
@@ Coverage Diff @@
## stable10 #35344 +/- ##
==============================================
+ Coverage 64.64% 64.64% +<.01%
Complexity 20093 20093
==============================================
Files 1289 1289
Lines 76946 76947 +1
Branches 1300 1300
==============================================
+ Hits 49738 49739 +1
Misses 26824 26824
Partials 384 384
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35344 +/- ##
==============================================
+ Coverage 64.64% 64.64% +<.01%
Complexity 20093 20093
==============================================
Files 1289 1289
Lines 76946 76947 +1
Branches 1300 1300
==============================================
+ Hits 49738 49739 +1
Misses 26824 26824
Partials 384 384
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #35324
Description
When doing a files:scan and entering the user id in the wrong case. The job tells, that no files are scanned. This PR fixes issue by learning correct uid from user manager. @pako81 since casing is not important in our uid policy, in my opinion this solution better than throwing an error. Do you think this PR is acceptable with this behavior?
Related Issue
Motivation and Context
Solving bugs.
How Has This Been Tested?
Types of changes
Checklist: