Skip to content

[Stable10] detect correct uid when even wrong casing in given uid for files:scan#35344

Merged
karakayasemi merged 1 commit intostable10from
backport-35324
May 28, 2019
Merged

[Stable10] detect correct uid when even wrong casing in given uid for files:scan#35344
karakayasemi merged 1 commit intostable10from
backport-35324

Conversation

@karakayasemi
Copy link
Copy Markdown
Contributor

Backport of #35324

Description

When doing a files:scan and entering the user id in the wrong case. The job tells, that no files are scanned. This PR fixes issue by learning correct uid from user manager. @pako81 since casing is not important in our uid policy, in my opinion this solution better than throwing an error. Do you think this PR is acceptable with this behavior?

Related Issue

Motivation and Context

Solving bugs.

How Has This Been Tested?

  • use files:scan command with wrong casing
  • it should detect correct uid and work

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@karakayasemi karakayasemi requested a review from phil-davis May 28, 2019 07:20
@karakayasemi karakayasemi self-assigned this May 28, 2019
@karakayasemi karakayasemi changed the title detect correct uid when even wrong casing in given uid for files:scan [Stable10] detect correct uid when even wrong casing in given uid for files:scan May 28, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2019

Codecov Report

Merging #35344 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35344      +/-   ##
==============================================
+ Coverage       64.64%   64.64%   +<.01%     
  Complexity      20093    20093              
==============================================
  Files            1289     1289              
  Lines           76946    76947       +1     
  Branches         1300     1300              
==============================================
+ Hits            49738    49739       +1     
  Misses          26824    26824              
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.78% <100%> (ø) 20093 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/Scan.php 71.91% <100%> (+0.09%) 74 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4558a3e...b035f69. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2019

Codecov Report

Merging #35344 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35344      +/-   ##
==============================================
+ Coverage       64.64%   64.64%   +<.01%     
  Complexity      20093    20093              
==============================================
  Files            1289     1289              
  Lines           76946    76947       +1     
  Branches         1300     1300              
==============================================
+ Hits            49738    49739       +1     
  Misses          26824    26824              
  Partials          384      384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.78% <100%> (ø) 20093 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/Scan.php 71.91% <100%> (+0.09%) 74 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4558a3e...b035f69. Read the comment docs.

@karakayasemi karakayasemi merged commit eca62b1 into stable10 May 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport-35324 branch May 28, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants