Skip to content

[Tests-Only] Add acceptance test to manage backend config for local storage mount#37015

Merged
phil-davis merged 1 commit intomasterfrom
manageBackendConfigForMount
Feb 28, 2020
Merged

[Tests-Only] Add acceptance test to manage backend config for local storage mount#37015
phil-davis merged 1 commit intomasterfrom
manageBackendConfigForMount

Conversation

@jasson99
Copy link
Copy Markdown
Contributor

Description

Add acceptance test to manage backend configuration for local storage mount using occ command.

Related Issue

#36704

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 requested a review from phil-davis February 25, 2020 11:18
@jasson99 jasson99 self-assigned this Feb 25, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2020

Codecov Report

Merging #37015 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37015   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19138    19138           
=========================================
  Files          1270     1270           
  Lines         74912    74912           
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
  Misses        26014    26014           
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.92% <ø> (ø) 19138 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63277f...9e77a0e. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2020

Codecov Report

Merging #37015 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37015   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19138    19138           
=========================================
  Files          1270     1270           
  Lines         74912    74912           
  Branches       1329     1329           
=========================================
  Hits          48507    48507           
  Misses        26014    26014           
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.92% <ø> (ø) 19138 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0640272...c2ca9f8. Read the comment docs.

@phil-davis
Copy link
Copy Markdown
Contributor

phil-davis commented Feb 26, 2020

Here is an example where I started to setup a Google Drive:

php occ files_external:list
+----------+--------------+--------------+---------------------+----------------------------------------------------------------------------------+---------+------------------+-------------------+
| Mount ID | Mount Point  | Storage      | Authentication Type | Configuration                                                                    | Options | Applicable Users | Applicable Groups |
+----------+--------------+--------------+---------------------+----------------------------------------------------------------------------------+---------+------------------+-------------------+
| 1        | /GoogleDrive | Google Drive | OAuth2              | configured: "false", client_id: "qwertyuiop", client_secret: "***", token: "***" |         | All              |                   |
+----------+--------------+--------------+---------------------+----------------------------------------------------------------------------------+---------+------------------+-------------------+

So that has configured client_id client_secret and token in the "Configuration" section.

So you could do examples with keys like that.

Somehow files_external:list knows to report the value of some keys as *** and not show the secret values. So that will also let you test the files_external:list --show-password command option.

Also test the output of occ files_external:config 1 key_name (not providing a value). In that case it is supposed to display the existing value.

Other ideas might be here: https://doc.owncloud.com/server/admin_manual/configuration/files/external_storage_configuration_gui.html

Copy link
Copy Markdown
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Please rebase and squash when you do the little changes. Then we should be able to merge.

@jasson99 jasson99 force-pushed the manageBackendConfigForMount branch from 1bc38ab to c2ca9f8 Compare February 28, 2020 06:46
@jasson99 jasson99 requested a review from phil-davis February 28, 2020 06:48
@phil-davis phil-davis merged commit ddbd391 into master Feb 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the manageBackendConfigForMount branch February 28, 2020 07:50
@phil-davis phil-davis mentioned this pull request May 14, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants