Include a migration to disable the enterprise_key app if present

[jvillafanez]

Description

Disable the enterprise_key app during the upgrade to 10.5.0.
A warning message will appear in the logs.
Requested as part of the new licensing.

Related Issue

#37510

Motivation and Context

How Has This Been Tested?

Manually checked with an upgrade from 10.4.1 to current master (~ 10.5.0beta2)

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[micbar]

LTGM

[micbar]

Tests are failing on server install

[codecov]

Codecov Report

Merging #37512 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #37512      +/-   ##
============================================
- Coverage     64.68%   64.67%   -0.01%     
- Complexity    19336    19339       +3     
============================================
  Files          1277     1278       +1     
  Lines         75535    75542       +7     
  Branches       1331     1331              
============================================
  Hits          48860    48860              
- Misses        26283    26290       +7     
  Partials        392      392              

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.84% <0.00%> (-0.01%)	19339.00 <3.00> (+3.00)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/Migrations/Version20200610110817.php	0.00% <0.00%> (ø)	3.00 <3.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890ef6e...619b32a. Read the comment docs.

[codecov]

Codecov Report

Merging #37512 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #37512      +/-   ##
============================================
- Coverage     64.68%   64.67%   -0.01%     
- Complexity    19336    19339       +3     
============================================
  Files          1277     1278       +1     
  Lines         75535    75542       +7     
  Branches       1331     1331              
============================================
  Hits          48860    48860              
- Misses        26283    26290       +7     
  Partials        392      392              

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.84% <0.00%> (-0.01%)	19339.00 <3.00> (+3.00)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/Migrations/Version20200610110817.php	0.00% <0.00%> (ø)	3.00 <3.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890ef6e...619b32a. Read the comment docs.

[codecov]

Codecov Report

Merging #37512 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #37512      +/-   ##
============================================
- Coverage     64.68%   64.67%   -0.01%     
- Complexity    19336    19339       +3     
============================================
  Files          1277     1278       +1     
  Lines         75535    75542       +7     
  Branches       1331     1331              
============================================
  Hits          48860    48860              
- Misses        26283    26290       +7     
  Partials        392      392              

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.84% <0.00%> (-0.01%)	19339.00 <3.00> (+3.00)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/Migrations/Version20200610110817.php	0.00% <0.00%> (ø)	3.00 <3.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890ef6e...619b32a. Read the comment docs.

[jvillafanez]

Migrations don't have tests, so I can't increase the coverage.
This has been tested manually.

[phil-davis]

It should get run in nightly https://github.com/owncloud/update-testing
e.g. https://drone.owncloud.com/owncloud/update-testing/862/1/5

which uses owncloud-daily-master-qa.tar.bz2

So after merging this, we will see if it all goes OK overnight.

[phil-davis]

@micbar IMO this does not need a separate changelog, it is part of the existing enterprise_app-related changes.

Please review again.