Add explicit favorite capability entry

[PVince81]

Description

Add explicit favorite capability entry
As it's already supported in OC 10, it's set to true.

Related Issue

For owncloud/ocis#354

Motivation and Context

This will make it possible for ocis-web to decide whether to enable the feature in the UI or not.
As this is not implemented yet in OCIS, the feature/capability will be disabled there.

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

@LukasHirt FYI

[PVince81]

@micbar FYI

this means that Phoenix running against OC <= 10.5 will not display the favorites feature

[PVince81]

added changelog entry

[phil-davis]

Could add an acceptance test scenario like https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiCapabilities/capabilities.feature#L80

Test for the new capability, and @skipOnOcV10.3 @skipOnOcV10.4 @skipOnOcV10.5

[PVince81]

not sure if there is much value in such test

[PVince81]

it's green, please approve

[codecov]

Codecov Report

Merging #37673 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37673   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
  Complexity    19363    19363           
=========================================
  Files          1281     1281           
  Lines         75628    75628           
  Branches       1333     1333           
=========================================
  Hits          48966    48966           
  Misses        26270    26270           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.03% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.93% <ø> (ø)	19363.00 <ø> (ø)

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/Capabilities.php	100.00% <ø> (ø)	2.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5574a5a...0cfbdfc. Read the comment docs.

[codecov]

Codecov Report

Merging #37673 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37673   +/-   ##
=========================================
  Coverage     64.74%   64.74%           
  Complexity    19363    19363           
=========================================
  Files          1281     1281           
  Lines         75628    75628           
  Branches       1333     1333           
=========================================
  Hits          48966    48966           
  Misses        26270    26270           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.03% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.93% <ø> (ø)	19363.00 <ø> (ø)

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/Capabilities.php	100.00% <ø> (ø)	2.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5574a5a...0cfbdfc. Read the comment docs.