Fix display of public link shares in case avatars are disabled

[pako81]

Description

Fix display of public link shares in case avatars are disabled

Related issue

https://github.com/owncloud/enterprise/issues/4190

Motivation and Context

This PR fixes the display of public link shares in case avatars are disabled through config.php. Previously, a "sharing is not allowed" message was displayed and public link was not visible in the sharing panel of the "All files" view. The reason for this was a missing check at https://github.com/owncloud/core/blob/master/apps/files/js/filelist.js#L1902 for avatars being enabled/disabled.

How Has This Been Tested?

Manually:

• setting 'enable_avatars' => false, in config.php
• create a folder and place some files inside that folder
• share that folder with another user
• (still as the same user) go in to the folder you just shared and try to create a public link on one of the files

Before this fix:

The public link was correctly created in DB but when leaving the sharing panel and trying to access it again via the "All files" view, a "sharing is not allowed" message was shown. It could be accessed via the "Shared with you" page only.

With this fix:

Public link is correctly displayed in the sharing panel of the "All files" view.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised
• Changelog item

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[codecov]

Codecov Report

Merging #37945 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37945   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19442    19442           
=========================================
  Files          1286     1286           
  Lines         76022    76022           
  Branches       1336     1336           
=========================================
  Hits          49196    49196           
  Misses        26432    26432           
  Partials        394      394           

Flag	Coverage Δ	Complexity Δ
#javascript	54.06% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.88% <ø> (ø)	19442.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a444c5...8a75b5e. Read the comment docs.

[karakayasemi]

LGTM!