Added connection_parameters to redis and redis.cluster config section in order to allow redis with TLS/SSL

[AlexAndBear]

Description

Since php-redis 5.3.0 it is possible to pass extra connection parameters as the last argument of Redis::Connect or RedisCluster::constructor.
This arguments can now be defined in the config.php redis.cluser:connection_parameters or redis:connection_parameters.
Due we don't rely on php-redis >= 5.3.0 we check if the extra connection parameters are supported and throw an exception if defined but not supported by the current version.

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/4368

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[mmattel]

pls do not forget to add a doc issue in case there is a config.sample change 😄

[AlexAndBear]

pls do not forget to add a doc issue in case there is a config.sample change

@mmattel done 👍

[AlexAndBear]

@jvillafanez So, I think the error suppression is nonsense, after changing lib/base.php as well, we get now a better error like connection refused instead of redis server went away. Can you have a closer look?

[jvillafanez]

just a little touch

[jvillafanez]

@janackermann could you post what you've tested for the change in the lib/base.php to ensure we're not missing anything? The code is executed quite early and I'm not sure if there is any scenario where it could break really bad.
I expect the exception to end up in the owncloud.log file.

Assuming it doesn't give any trouble, the code looks good to me.

[AlexAndBear]

@jvillafanez
Without change:

1. Enter faulty redis Data
2. Open owncloud in Browser
3. Generic Error Page appears
4. Redis exception: Redis Server went away in Logos

With Change:

1. Enter faulty redis Data
2. Open owncloud in Browser
3. Generic Error Page appears
4. Redis exceptions: Connection refused in Logs

[AlexAndBear]

@jvillafanez If this is a blocker, i will revert the Changes here, as this is not Part of the ticket

[jvillafanez]

We should also check what happens with the command line, ocs and webdav.

[AlexAndBear]

Encountered webdav erros which won't happen on master, revert these changes, leave it for now, not context of the issue. Please review again @jvillafanez

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[jnweiger]

Confirmed decent error handling in 10.7.0 RC1

• with faulty redis port number, the logs have

"message":"Exception: {\"Exception\":\"RedisException\",\"Message\":\"Connection refused\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/RedisFactory.php(117): Redis->connect()\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/RedisFactory.php(139): OC\\\\RedisFactory->create()\\n#2 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Memcache\\\/Redis.php(37): OC\\\\RedisFactory->getInstance()\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Memcache\\\/Factory.php(131): OC\\\\Memcache\\\\Redis->__construct()\\n#4 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(731): OC\\\\Memcache\\\\Factory->createLocking()\\n#5 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/pimple\\\/pimple\\\/src\\\/Pimple\\\/Container.php(118): OC\\\\Server->OC\\\\{closure}(*** sensitive parameters replaced ***)\\n#6 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Utility\\\/SimpleContainer.php(108): Pimple\\\\Container->offsetGet()\\n#7 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/ServerContainer.php(86): OC\\\\AppFramework\\\\Utility\\\\SimpleContainer->query()\\n#8 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(1511): OC\\\\ServerContainer->query()\\n#9 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Files\\\/View.php(124): OC\\\\Server->getLockingProvider()\\n#10 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(179): OC\\\\Files\\\\View->__construct()\\n#11 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/pimple\\\/pimple\\\/src\\\/Pimple\\\/Container.php(118): OC\\\\Server->OC\\\\{closure}(*** sensitive parameters replaced ***)\\n#12 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Utility\\\/SimpleContainer.php(108): Pimple\\\\Container->offsetGet()\\n#13 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/ServerContainer.php(86): OC\\\\AppFramework\\\\Utility\\\\SimpleContainer->query()\\n#14 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(942): OC\\\\ServerContainer->query()\\n#15 \\\/var\\\/www\\\/owncloud\\\/lib\\\/base.php(754): OC\\\\Server->getEncryptionManager()\\n#16 \\\/var\\\/www\\\/owncloud\\\/lib\\\/base.php(668): OC::registerEncryptionWrapper()\\n#17 \\\/var\\\/www\\\/owncloud\\\/lib\\\/base.php(1058): OC::init()\\n#18 \\\/var\\\/www\\\/owncloud\\\/index.php(53): require_once('\\\/var\\\/www\\\/ownclo...')\\n#19 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/RedisFactory.php\",\"Line\":117}"}

---

• Or with added connection_parameters with stock ubuntu 20.04 php-redis 5.1.1+4.3.0-1:

"message":"Exception: {\"Exception\":\"UnexpectedValueException\",\"Message\":\"php-redis extension must be version 5.3.0 or higher to support connection parameters\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/RedisFactory.php(139): OC\\\\RedisFactory->create()\\n#1 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Memcache\\\/Redis.php(37): OC\\\\RedisFactory->getInstance()\\n#2 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Memcache\\\/Factory.php(131): OC\\\\Memcache\\\\Redis->__construct()\\n#3 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(731): OC\\\\Memcache\\\\Factory->createLocking()\\n#4 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/pimple\\\/pimple\\\/src\\\/Pimple\\\/Container.php(118): OC\\\\Server->OC\\\\{closure}(*** sensitive parameters replaced ***)\\n#5 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Utility\\\/SimpleContainer.php(108): Pimple\\\\Container->offsetGet()\\n#6 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/ServerContainer.php(86): OC\\\\AppFramework\\\\Utility\\\\SimpleContainer->query()\\n#7 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(1511): OC\\\\ServerContainer->query()\\n#8 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Files\\\/View.php(124): OC\\\\Server->getLockingProvider()\\n#9 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(179): OC\\\\Files\\\\View->__construct()\\n#10 \\\/var\\\/www\\\/owncloud\\\/lib\\\/composer\\\/pimple\\\/pimple\\\/src\\\/Pimple\\\/Container.php(118): OC\\\\Server->OC\\\\{closure}(*** sensitive parameters replaced ***)\\n#11 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Utility\\\/SimpleContainer.php(108): Pimple\\\\Container->offsetGet()\\n#12 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/ServerContainer.php(86): OC\\\\AppFramework\\\\Utility\\\\SimpleContainer->query()\\n#13 \\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/Server.php(942): OC\\\\ServerContainer->query()\\n#14 \\\/var\\\/www\\\/owncloud\\\/lib\\\/base.php(754): OC\\\\Server->getEncryptionManager()\\n#15 \\\/var\\\/www\\\/owncloud\\\/lib\\\/base.php(668): OC::registerEncryptionWrapper()\\n#16 \\\/var\\\/www\\\/owncloud\\\/lib\\\/base.php(1058): OC::init()\\n#17 \\\/var\\\/www\\\/owncloud\\\/index.php(53): require_once('\\\/var\\\/www\\\/ownclo...')\\n#18 {main}\",\"File\":\"\\\/var\\\/www\\\/owncloud\\\/lib\\\/private\\\/RedisFactory.php\",\"Line\":104}"}