Skip to content

Remove google plus share button due to service has been declined #38705

Merged
AlexAndBear merged 4 commits intomasterfrom
remove-google-plus-share-button
May 6, 2021
Merged

Remove google plus share button due to service has been declined #38705
AlexAndBear merged 4 commits intomasterfrom
remove-google-plus-share-button

Conversation

@AlexAndBear
Copy link
Copy Markdown

@AlexAndBear AlexAndBear commented May 6, 2021

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot May 6, 2021
@pmaier1
Copy link
Copy Markdown
Contributor

pmaier1 commented May 6, 2021

Basically 👍 Did you try whether it really doesn't work anymore? There is some successor of Google+ https://en.wikipedia.org/wiki/Google_Currents

@JammingBen
Copy link
Copy Markdown
Contributor

We also have buttons in the sidebar:

image

@AlexAndBear
Copy link
Copy Markdown
Author

@pmaier1 yes, told me that it isn't available for private and brand users anymore

@AlexAndBear
Copy link
Copy Markdown
Author

@JammingBen resolved

Copy link
Copy Markdown
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR link in changelog, then 🚀

Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@AlexAndBear
Copy link
Copy Markdown
Author

@pmaier1 i would like to merge if you confirm.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexAndBear AlexAndBear merged commit ffbc552 into master May 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-google-plus-share-button branch May 6, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants