implement fallback response type for ocm discover#38751
Merged
karakayasemi merged 1 commit intomasterfrom May 19, 2021
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
karakayasemi
changed the title
karakayasemi
force-pushed
the
implement-ocm-discover-fallback
branch
from
5b0b3e3 to
a91c54c
Compare
phil-davis
reviewed
May 19, 2021
karakayasemi
force-pushed
the
implement-ocm-discover-fallback
branch
from
a91c54c to
8481014
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jvillafanez
approved these changes
May 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some ocm-provider implementations are slightly different than us. This pr implements fallback for different ocm-provider API responses.
Related Issue
https://github.com/owncloud/enterprise/issues/4522#issuecomment-841884476
Motivation and Context
Prevent unnecesary error logs.
How Has This Been Tested?
Tested federated sharing functionality manually with different ocm providers.
Screenshots (if appropriate):
Types of changes
Checklist: