[tests-only] Added acceptance tests for allow certain groups to create link share

[kiranparajuli589]

Description

Acceptance tests have been added to the new feature at #38980

Related Issue

• Fixes Add test coverage for Allow public link sharing only for certain groups #39002

Motivation and Context

How Has This Been Tested?

• 🤖

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[kiranparajuli589]

failed on php-style

[AlexAndBear]

Beautiful! 🚀

I would require one more scenario:
Edge-Case if allow sharing only for certain groups is enabled but no group is set, creating shares should be possible

Multiple groups combinations could also be possible whether in user or sharing only for certain groups setting but this should be already covered by unit tests

[kiranparajuli589]

Beautiful!

I would require one more scenario:
Edge-Case if allow sharing only for certain groups is enabled but no group is set, creating shares should be possible

Multiple groups combinations could also be possible whether in user or sharing only for certain groups setting but this should be already covered by unit tests

I'll add them right away

[ownclouders]

💥 Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31259/172/1

[kiranparajuli589]

Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31259/172/1

random failure

curl: (6) Could not resolve host: proxy
--
34 | Server on http://proxy is down or not working correctly.
35 | make: *** [test-acceptance-api] Error 98

[ownclouders]

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31260/151/1

[ownclouders]

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31261/151/1

[AlexAndBear]

Random crash again :/ restarted.

[AlexAndBear]

Something mixed up, can you rebase ?

[ownclouders]

💥 Acceptance tests pipeline webUISharingPublic2-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/31269/151/1

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[phil-davis]

This is an interesting scenario. If the admin enables this feature and specifies no groups in the "allow list" then what should happen? Should that mean that there are no users allowed to create public links? (Effectively public links are disabled) Or do we keep the behavior written in this scenario - setting public_share_sharers_groups_allowlist_enabled has no effect in this case.

@janackermann

[AlexAndBear]

@phil-davis I decided myself if public_share_sharers_groups_allowlist_enabled but no groups are set, that there will be no public share restriction, to keep support cases as low as possible.
("Hey we don't see the sharing tab anymore").

But for sure this needs to be addressed in PB2