Redesign group list in the user settings view#39262
Conversation
AlexAndBear
force-pushed
the
redesign-user-settings-groups
branch
from
c78ea01 to
0900318
Compare
AlexAndBear
force-pushed
the
redesign-user-settings-groups
branch
from
613f554 to
a17f1ce
Compare
In the screen-shot I had just deleted group "m123" "something" (tm) needs to happen after a group is deleted, to refresh the user list to "something". Either go back to listing "Everyone" or just empty the list completely or? Note: this looks like it is issue #29057 which the stale bot just closed. I will leave it closed, because I have reported here and we can do something reasonable in this PR. |
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Just minor edits to the changelog, while you look at what tests are failing and need adjusting.
|
Another issue popped up (was pre existing)
Fixed |
AlexAndBear
force-pushed
the
redesign-user-settings-groups
branch
from
b4c1b0a to
1f9feb5
Compare
|
@phil-davis after deletion of a group, we now will be redirected to everyone |
AlexAndBear
force-pushed
the
redesign-user-settings-groups
branch
2 times, most recently
from
a363bda to
5fe8fd9
Compare
|
@phil-davis CI should be green now, ready to have a second look =) |
AlexAndBear
force-pushed
the
redesign-user-settings-groups
branch
from
5fe8fd9 to
ad5a5be
Compare
| } | ||
|
|
||
| /** | ||
| * @Then the user count of group :group should not be displayed on the webUI | ||
| * | ||
| * @param string $group | ||
| * | ||
| * @return void | ||
| */ | ||
| public function theUserCountOfGroupShouldNotBeDisplayedOnTheWebui($group) { | ||
| $count = $this->usersPage->getUserCountOfGroup($group); | ||
| Assert::assertNull( | ||
| $count, | ||
| "Failed asserting that user count of group $group is not displayed" | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't need this anymore, as we show the correct amount even 0
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
I can't "break" it any more. I manually tried putting users into various groups, and as subadmin of groups, then deleting the group... and it works nicely.
3 participants
Description
Enhancement: Redesign group list in the user settings view
Before this PR, the group list settings were confusing as the user needs to
click on a group first before the trash bin icon appears to delete a group.
As well the user count was nondescript.
With this PR, a redesign takes care of those issues and also fixes the problem
that while deleting a group in the group list,
it was still available in the user group list.
Furthermore, after deleting a group, the user will be redirected to the
'Everyone' group summary view.
Also fixes an issue where the 'active'-class on a newly created group
was duplicated.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Before
After
Types of changes
Checklist: