Prevent encrypted files from being corrupted when overwriting them#39623
Merged
JammingBen merged 3 commits intomasterfrom Dec 28, 2021
Merged
Prevent encrypted files from being corrupted when overwriting them#39623JammingBen merged 3 commits intomasterfrom
JammingBen merged 3 commits intomasterfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
Author
|
Not sure about the target branch here. This has to land in 10.9.1, ideally without all other changes in master that have been made in the meantime. But I think master is fine, we can cherry pick the commits if needed to a release-10.9.1 branch. |
JammingBen
added a commit
that referenced
this pull request
Dec 28, 2021
JammingBen
added a commit
that referenced
this pull request
Dec 28, 2021
phil-davis
pushed a commit
that referenced
this pull request
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where overwriting an encrypted file by a share recipient would corrupt it.
This is a regression which was introduced by #39516. An early return was implement in the
getHeader()method which caused trouble with a) part files and b) the fix-encrypted-version-command. Therefore I reverted the change as it seemed to be an optimization only.Related Issue
Types of changes
Checklist: