Fix issue restoring versions from the trashbin after sharing#39822
Merged
jvillafanez merged 2 commits intomasterfrom Feb 28, 2022
Merged
Fix issue restoring versions from the trashbin after sharing#39822jvillafanez merged 2 commits intomasterfrom
jvillafanez merged 2 commits intomasterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
suggested changes
Feb 28, 2022
A folder contains a file with multiple versions. The folder is shared with another user. That user deletes the shared file (with the versions). Then, that user restores the file. At that point, the versions were broken due to a bad signature.
a1af639 to
bf12593
Compare
AlexAndBear
approved these changes
Feb 28, 2022
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








A folder contains a file with multiple versions. The folder is shared
with another user. That user deletes the shared file (with the
versions). Then, that user restores the file. At that point, the
versions were broken due to a bad signature.
Description
According to docs, versions are copied as such, so the signature in the file doesn't change. Since the signature doesn't change, the "encrypted" column shouldn't change neither.
Even if we're moving versions, we won't increase the "encrypted" value for the version in order to not disrupt the signature in the file.
Related Issue
#39664
Motivation and Context
Versions of the file were broken after following the steps described in the issue
How Has This Been Tested?
Manually tested following the steps
Screenshots (if appropriate):
Types of changes
Checklist: