Skip to content

Drop PHP 7.3#40122

Closed
phil-davis wants to merge 1 commit intomasterfrom
drop-php-7.3-202206
Closed

Drop PHP 7.3#40122
phil-davis wants to merge 1 commit intomasterfrom
drop-php-7.3-202206

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

Description

This is a PoC demonstrating the changes needed to drop PHP 7.3

Note: because of issue #40103 I cannot do composer update in this PR, or in core master. So the PHP dependencies may be a bit out-of-date here. After that issue is resolved (for example, by merging the guzzle v7 PR), then I can rebase this and update the dependencies.

composer found the following dependencies that it could update:

php /usr/local/bin/composer install
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Package operations: 0 installs, 4 updates, 2 removals
  - Removing laminas/laminas-zendframework-bridge (1.4.1)
  - Removing container-interop/container-interop (1.2.0)
  - Upgrading psr/container (1.1.1 => 1.1.2): Extracting archive
  - Upgrading laminas/laminas-servicemanager (3.7.0 => 3.11.2): Extracting archive
  - Upgrading laminas/laminas-filter (2.12.0 => 2.14.0): Extracting archive
  - Upgrading laminas/laminas-inputfilter (2.12.1 => 2.13.0): Extracting archive

apps/files_external/3rdparty is also updated.

Other things that could be done are:

  • bump from phpunit v9 to v10 (if phpunit v10 gets released "soon")
  • bump Symfony v4 to v5
  • check other major versions of dependencies in composer.json and see what could be updated

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

The previous PR was #40005

@phil-davis phil-davis self-assigned this Jun 7, 2022
@phil-davis phil-davis mentioned this pull request Jun 7, 2022
11 tasks
@owncloud owncloud deleted a comment from update-docs bot Jun 7, 2022
@phil-davis
Copy link
Copy Markdown
Contributor Author

Passed - good. This will need to be planned for some future release.

@mmattel
Copy link
Copy Markdown
Contributor

mmattel commented Jun 13, 2022

Docs relevant when going to be merged.
We have attributes defining the supported PHP releases...

@phil-davis phil-davis force-pushed the drop-php-7.3-202206 branch 2 times, most recently from 1c7a249 to 819851b Compare June 17, 2022 11:38
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Jun 17, 2022

💥 Acceptance tests pipeline apiProxySmoke-8-8-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/36061/171

@ownclouders
Copy link
Copy Markdown
Contributor

💥 Acceptance tests pipeline webUICreateDelete-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/36061/120

@phil-davis phil-davis force-pushed the drop-php-7.3-202206 branch from 819851b to a0d00a5 Compare June 17, 2022 11:40
@phil-davis phil-davis force-pushed the drop-php-7.3-202206 branch from a0d00a5 to 3a08e76 Compare June 27, 2022 10:53
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis mentioned this pull request Jul 28, 2022
11 tasks
@phil-davis
Copy link
Copy Markdown
Contributor Author

See #40248 for an updated PR

@phil-davis phil-davis closed this Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants