Skip to content

Drop PHP 7.3#40248

Closed
phil-davis wants to merge 2 commits intomasterfrom
drop-php-7.3-202207
Closed

Drop PHP 7.3#40248
phil-davis wants to merge 2 commits intomasterfrom
drop-php-7.3-202207

Conversation

@phil-davis
Copy link
Copy Markdown
Contributor

@phil-davis phil-davis commented Jul 28, 2022

Description

This is a PoC demonstrating the changes needed to drop PHP 7.3

composer found the following dependencies that it could update:

Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Package operations: 0 installs, 5 updates, 2 removals
  - Removing laminas/laminas-zendframework-bridge (1.4.1)
  - Removing container-interop/container-interop (1.2.0)
  - Upgrading psr/container (1.1.1 => 1.1.2): Extracting archive
  - Upgrading laminas/laminas-servicemanager (3.7.0 => 3.16.0): Extracting archive
  - Upgrading laminas/laminas-validator (2.19.0 => 2.23.0): Extracting archive
  - Upgrading laminas/laminas-filter (2.12.0 => 2.17.0): Extracting archive
  - Upgrading laminas/laminas-inputfilter (2.12.1 => 2.19.1): Extracting archive

Other things that could be done are:

  • bump from phpunit v9 to v10 (if phpunit v10 gets released "soon")
  • bump Symfony v4 to v5
  • check other major versions of dependencies in composer.json and see what could be updated

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

The previous PR was #40122

@phil-davis phil-davis self-assigned this Jul 28, 2022
@update-docs
Copy link
Copy Markdown

update-docs bot commented Jul 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis phil-davis mentioned this pull request Jul 28, 2022
11 tasks
@phil-davis phil-davis force-pushed the drop-php-7.3-202207 branch from 38524df to 04a7996 Compare August 17, 2022 04:23
@ownclouders
Copy link
Copy Markdown
Contributor

ownclouders commented Aug 17, 2022

💥 Acceptance tests pipeline apiShareReshareToShares3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/36617/67

@phil-davis phil-davis force-pushed the drop-php-7.3-202207 branch from 04a7996 to e95d8d6 Compare August 17, 2022 10:04
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis force-pushed the drop-php-7.3-202207 branch from e95d8d6 to 206e6af Compare August 18, 2022 08:42
@phil-davis phil-davis force-pushed the drop-php-7.3-202207 branch from 206e6af to 10cf85f Compare August 18, 2022 12:58
@phil-davis phil-davis mentioned this pull request Aug 31, 2022
11 tasks
@phil-davis
Copy link
Copy Markdown
Contributor Author

See #40323

@phil-davis phil-davis closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants