Add configuration option to bypass proxy settings for some domains#40148
Merged
phil-davis merged 2 commits intomasterfrom Jun 23, 2022
Merged
Add configuration option to bypass proxy settings for some domains#40148phil-davis merged 2 commits intomasterfrom
phil-davis merged 2 commits intomasterfrom
Conversation
92b4f9a to
d9acaa4
Compare
Contributor
|
Hooking myself in, needs a |
Contributor
|
@jvillafanez you have status |
phil-davis
reviewed
Jun 20, 2022
Contributor
phil-davis
left a comment
There was a problem hiding this comment.
This will need a changelog.
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
Jun 23, 2022
phil-davis
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
The
proxyconfig option allows the admin to set a proxy that will be used for the ownCloud requests. The newproxy_ignoreoption will allow the bypass of that proxy for specific domainsRelated Issue
https://github.com/owncloud/enterprise/issues/4979
Motivation and Context
Some domains might not need to go through the proxy.
How Has This Been Tested?
Manually tested
proxysetting in ownCloud to use the proxy configured in step 1With the proxy active, the proxy should log the request. It might also reject the request due to SSL certificates, but an error should appear in the proxy.
Setting the new
'proxy_ignore' => ['.owncloud.com'](for example), the market app is expected to load successfully without going through the proxy, so there shouldn't be any activity there.Screenshots (if appropriate):
Types of changes
Checklist: