Hide last log in column if disabled#40771
Merged
phil-davis merged 2 commits intomasterfrom May 4, 2023
Merged
Conversation
phil-davis
commented
May 4, 2023
| if ($('#CheckboxLastLogin').is(':checked')) { | ||
| $("#userlist .lastLogin").show(); | ||
| } else { | ||
| $("#userlist .lastLogin").hide(); |
Contributor
Author
There was a problem hiding this comment.
This fixes the issue. But I also tested other checkbox settings like "Show Creation Time". The setting of that works fine when browsing away and back, or logging out and logging in again. But the CheckboxCreationTime code here in users.js does not have the else that I have added here for CheckboxLastLogin. So I do not understand completely - I was expecting CheckboxCreationTime to have the same issue, but it does not have the issue.
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
May 4, 2023
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the Users page is first displayed, if the "Show last log in" setting is off, the hide the "Last Login" column.
1st commit adds 2 new acceptance test scenario, the 2nd scenario fails before the fix.
2nd commit fixes the issue and the tests pass.
Related Issue
How Has This Been Tested?
CI and manual check.
Before the fix: "Last Login" column is shown, but the checkbox is off - bad.
fter the fix: "Last Login" column is not shown - good.
Types of changes
Checklist: