Conversation
phil-davis
reviewed
May 11, 2023
phil-davis
approved these changes
May 11, 2023
Contributor
|
💥 Acceptance tests pipeline apiProxySmoke-8-4-maria10.2-php7.4 failed. The build has been cancelled. |
Author
|
Contributor
|
https://drone.owncloud.com/owncloud/core/38421/174/3 I restarted CI. |
|
Kudos, SonarCloud Quality Gate passed! |
Author
|
@DeepDiver1975 are you ok with this change? |
jnweiger
approved these changes
May 11, 2023
Contributor
jnweiger
left a comment
jnweiger
left a comment
There was a problem hiding this comment.
Tested the patc with both, an upgrade to 10.12.1 and a fresh installed 10.12.1
This fixed the issue in both cases for me.
Thanks.
mmattel
approved these changes
May 11, 2023
Contributor
mmattel
left a comment
mmattel
left a comment
There was a problem hiding this comment.
I have locally checked with this change if things are working again - confirmed, all ok 👍
IljaN
approved these changes
May 12, 2023
shokri-navid
pushed a commit
to pondersource/core
that referenced
this pull request
Jul 16, 2023
* align to new authorization URI * add changelog * add links in changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align to new Google authorization URI in order to make GDrive integration working again.
Related Issue
invalid token format#40777Motivation and Context
Core 10.12.1 brought an update of the google/apiclient from version 2.12.6 to 2.13.1. However, in version 2.13.0 the accounts.google.com authorization URI has been updated. This change breaks old code that uses
setApprovalPrompt('force')instead of the newersetPrompt('consent')method, as this endpoint does not support the legacy approval prompt parameter.Sources:
How Has This Been Tested?
Manually on a fresh or updated 10.12.1 instance. Without this fix new GDrive external storages cannot be mounted, with it integration is working again.
Types of changes
Checklist: