Add loginInOwnCloud to Log::$methodsWithSensitiveParameters#40792
Merged
phil-davis merged 3 commits intomasterfrom May 17, 2023
Merged
Add loginInOwnCloud to Log::$methodsWithSensitiveParameters#40792phil-davis merged 3 commits intomasterfrom
phil-davis merged 3 commits intomasterfrom
Conversation
Author
|
Not sure if unit tests are needed. |
added 2 commits
May 16, 2023 17:06
jvillafanez
approved these changes
May 16, 2023
phil-davis
approved these changes
May 16, 2023
Contributor
|
💥 Acceptance tests pipeline webUISharingExt1-git-chrome-maria10.2-php7.4 failed. The build has been cancelled. |
Contributor
|
I restarted CI - let's see if it passes this morning. |
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
add-loginInOwnCloud-to-methodsWithSensitiveParameters
branch
DeepDiver1975
pushed a commit
that referenced
this pull request
May 25, 2023
…sWithSensitiveParameters Add loginInOwnCloud to Log::$methodsWithSensitiveParameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
loginInOwnCloudcontains sensitive data in the argument list and needs therefore to be added to the list of methods where sensitive parameters are being obfuscated.How Has This Been Tested?
Types of changes
Checklist: